-
-
Notifications
You must be signed in to change notification settings - Fork 610
chore: defensive program #1294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: defensive program #1294
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate Unit Tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## antd-5.x #1294 +/- ##
=========================================
Coverage 97.78% 97.78%
=========================================
Files 77 77
Lines 7594 7595 +1
Branches 1153 1153
=========================================
+ Hits 7426 7427 +1
Misses 162 162
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
根据 #1266 截图描述,问题出现在 effect 卸载时 ref 的元素被清理。但是实际看了一圈并不会有这种情况,test case 中也无法复现。
由于 #1266 (comment) 并没有提供复现。这里仅仅做防御性编程,保证卸载时铆定的元素是装载时的元素。
close #1266
close #1288