-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add npx
prefix before react-native
command
#2035
docs: add npx
prefix before react-native
command
#2035
Conversation
Considering what you said in the issue comment; should these all be |
Hm, yeah I wrote that, but I was wondering is it actually correct and I think we should only add |
init should be the only command to run with npx, and yes it should have the @-latest see this PR for more details -> facebook/react-native-website#3732 |
Okay, thanks for information. I don't know if it is doable but I think we should somehow "block" running any command besides |
That's correct |
e45b02b
to
ff01c2d
Compare
Update: I added |
After internal talk with @thymikee, actually what is the reason behind this we should only use The problem is that when we're saying to users to use either npm / yarn to run commands, in case of npm there's a problem because user needs to add command to |
ff01c2d
to
8be7da9
Compare
8be7da9
to
4a6df74
Compare
Hey, so after internal discussion, the conclusion is:
I updated this PR to match above requirements. cc. @kelset @cortinico mind looking at changes? 🙏 |
@huntie this modifies README of metro plugin slightly, please make sure to adjust this in the core |
…39074) Summary: Pull Request resolved: facebook#39074 Changelog: [Internal] Publish new versions of `react-native/community-cli-plugin` and `react-native/dev-middleware` (which are now in a minimum viable state) for early integrators. Also syncs final upstream changes from CLI: - react-native-community/cli#2035 - react-native-community/cli#2052 #publish-packages-to-npm bypass-github-export-checks Reviewed By: motiz88 Differential Revision: D48465522 fbshipit-source-id: 23d01b687bff73861964d1b3a718583be829e686
…39074) Summary: Pull Request resolved: facebook#39074 Changelog: [Internal] Publish new versions of `react-native/community-cli-plugin` and `react-native/dev-middleware` (which are now in a minimum viable state) for early integrators. Also syncs final upstream changes from CLI: - react-native-community/cli#2035 - react-native-community/cli#2052 #publish-packages-to-npm bypass-github-export-checks Reviewed By: motiz88 Differential Revision: D48465522 fbshipit-source-id: 8f92a125aaa6c9268b716fdfa7fac3191c844eca
…39074) Summary: Pull Request resolved: facebook#39074 Changelog: [Internal] Publish new versions of `react-native/community-cli-plugin` and `react-native/dev-middleware` (which are now in a minimum viable state) for early integrators. Also syncs final upstream changes from CLI: - react-native-community/cli#2035 - react-native-community/cli#2052 #publish-packages-to-npm bypass-github-export-checks Reviewed By: motiz88 Differential Revision: D48465522 fbshipit-source-id: fbaadec847667cd7153f455a6f40107bc9377d17
…39074) Summary: Pull Request resolved: facebook#39074 Changelog: [Internal] Publish new versions of `react-native/community-cli-plugin` and `react-native/dev-middleware` (which are now in a minimum viable state) for early integrators. Also syncs final upstream changes from CLI: - react-native-community/cli#2035 - react-native-community/cli#2052 #publish-packages-to-npm bypass-github-export-checks Reviewed By: motiz88 Differential Revision: D48465522 fbshipit-source-id: fd755855cddb58bfa9006c7930227bd54816465c
…39074) Summary: Pull Request resolved: facebook#39074 Changelog: [Internal] Publish new versions of `react-native/community-cli-plugin` and `react-native/dev-middleware` (which are now in a minimum viable state) for early integrators. Also syncs final upstream changes from CLI: - react-native-community/cli#2035 - react-native-community/cli#2052 #publish-packages-to-npm bypass-github-export-checks Reviewed By: motiz88 Differential Revision: D48465522 fbshipit-source-id: 28082b7cfb52eb80318ae9205f947e3d819ff6cb
…39074) Summary: Pull Request resolved: facebook#39074 Changelog: [Internal] Publish new versions of `react-native/community-cli-plugin` and `react-native/dev-middleware` (which are now in a minimum viable state) for early integrators. Also syncs final upstream changes from CLI: - react-native-community/cli#2035 - react-native-community/cli#2052 #publish-packages-to-npm bypass-github-export-checks Reviewed By: motiz88 Differential Revision: D48465522 fbshipit-source-id: 4b0dd056c0a5df5f6ca47da9f07dcc45ea41834f
…39074) Summary: Pull Request resolved: facebook#39074 Changelog: [Internal] Publish new versions of `react-native/community-cli-plugin` and `react-native/dev-middleware` (which are now in a minimum viable state) for early integrators. Also syncs final upstream changes from CLI: - react-native-community/cli#2035 - react-native-community/cli#2052 #publish-packages-to-npm bypass-github-export-checks Reviewed By: motiz88 Differential Revision: D48465522 fbshipit-source-id: e4aa3fbe49c1c0f9a5e04a42e653d96aa8b5619a
…39074) Summary: Pull Request resolved: facebook#39074 Changelog: [Internal] Publish new versions of `react-native/community-cli-plugin` and `react-native/dev-middleware` (which are now in a minimum viable state) for early integrators. Also syncs final upstream changes from CLI: - react-native-community/cli#2035 - react-native-community/cli#2052 #publish-packages-to-npm bypass-github-export-checks Reviewed By: motiz88 Differential Revision: D48465522 fbshipit-source-id: da761433fb62eb2ff82a43898aec501a73c40f32
…39074) Summary: Pull Request resolved: facebook#39074 Changelog: [Internal] Publish new versions of `react-native/community-cli-plugin` and `react-native/dev-middleware` (which are now in a minimum viable state) for early integrators. Also syncs final upstream changes from CLI: - react-native-community/cli#2035 - react-native-community/cli#2052 #publish-packages-to-npm bypass-github-export-checks Reviewed By: motiz88 Differential Revision: D48465522 fbshipit-source-id: 692d245d02c5880b30fa49b885aa599ced06cfd1
Summary: Pull Request resolved: #39074 Changelog: [Internal] Publish new versions of `react-native/community-cli-plugin` and `react-native/dev-middleware` (which are now in a minimum viable state) for early integrators. Also syncs final upstream changes from CLI: - react-native-community/cli#2035 - react-native-community/cli#2052 #publish-packages-to-npm bypass-github-export-checks Reviewed By: motiz88 Differential Revision: D48465522 fbshipit-source-id: 987280996938af35b752b998969ea112a15deb57
Summary:
Closes #2031
There are people who just copy and pastes commands from docs, and it is not allowed to have globally installed
react-native
package, so I synced every command in docs, warning and errors - to havenpx
prefix beforereact-native
for those who just copy and pastes commands into terminal :)Test Plan:
Just read it :)
Checklist