Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): fix loadConfig() failing with "missing loader for extension" #2550

Merged

Conversation

tido64
Copy link
Contributor

@tido64 tido64 commented Nov 8, 2024

Summary:

Part 2 of #2549 because I had missed a spot, even though I thought I had tested this properly.

Test Plan:

This is enough to trigger the error:

node -p 'require("@react-native-community/cli").loadConfig({})'

Checklist

  • Documentation is up to date to reflect these changes.
  • Follows commit message convention described in CONTRIBUTING.md

Copy link
Member

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I thought I checked that place and missed it too 🙈

@thymikee thymikee merged commit 69ac4cf into react-native-community:main Nov 8, 2024
4 of 10 checks passed
@tido64 tido64 deleted the tido/fix-loadconfig-sync-2 branch November 8, 2024 12:25
@thymikee
Copy link
Member

thymikee commented Nov 8, 2024

Released in v15.1.2

@tido64
Copy link
Contributor Author

tido64 commented Nov 8, 2024

Released in v15.1.2

Thanks for the super quick turnaround!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants