feat: Support required arguments in CLI commands #2658
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While doing some work on
react-native bundle
I noticed some arguments we require are actually notrequiredOption
s in Commander, and I was surprised that there was no way to mark an option required in config.This adds the
required
field toCommandOption
and passes it through so that we can more easily validate and emit user-actionable errors.Test Plan
Made these changes locally (with
link
) against RN 0.80-rc.0, and tested by addingrequired
to thebundle
command:Before
path.dirname(undefined)
After
Checklist
react-native
checkout (instructions).NOTE: e2e tests are hanging for me so I wasn't able to validate the new tests