Fix plistPath when using a prebuilt binary (appPath) #2705
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix plist path in
installApp
when running with a prebuilt binary (whenappPath
is set) located at a custom path.As discussed with @thymikee here:
#2517 (comment)
See more discussion with @thymikee here:
#2517 (comment)
Test Plan
Unfortunately, there are no tests for the
--binary-path
option (which is probably also why this feature broke at some point), but I see it as out of scope for this PR to correct that, so testing will have to be done manually by runningWith a prebuilt binary and validate that it actually installs and launches the app.
Checklist
react-native
checkout (instructions).