Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translated Page #169

Merged
merged 13 commits into from
Jun 26, 2022
Merged

Translated Page #169

merged 13 commits into from
Jun 26, 2022

Conversation

NegiAkash890
Copy link
Contributor

Translated start-a-new-react-project.md to Hindi

Part of #168

Translated start-a-new-react-project.md to Hindi
Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NegiAkash890 Great start.

I have started the review. Reviewed couple of lines and added some comments. May be you can refer those comments and revisit the whole file one more time.
Also refer this #2 for glossary, which will have details of commonly translated words, the words which we are not translating this will help you with your translations.

Reviewed till line 9

beta/src/pages/learn/start-a-new-react-project.md Outdated Show resolved Hide resolved
beta/src/pages/learn/start-a-new-react-project.md Outdated Show resolved Hide resolved
@arshadkazmi42 arshadkazmi42 added the 1st Review First phase of review label Dec 9, 2021
Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on the fixes.

I have added two more small comments. once those are fixed, I will continue with rest of the file review.

beta/src/pages/learn/start-a-new-react-project.md Outdated Show resolved Hide resolved
beta/src/pages/learn/start-a-new-react-project.md Outdated Show resolved Hide resolved
Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fixes.

Added some more comments till line 50.

Can work on fixing these.

beta/src/pages/learn/start-a-new-react-project.md Outdated Show resolved Hide resolved
beta/src/pages/learn/start-a-new-react-project.md Outdated Show resolved Hide resolved
beta/src/pages/learn/start-a-new-react-project.md Outdated Show resolved Hide resolved
beta/src/pages/learn/start-a-new-react-project.md Outdated Show resolved Hide resolved
beta/src/pages/learn/start-a-new-react-project.md Outdated Show resolved Hide resolved
beta/src/pages/learn/start-a-new-react-project.md Outdated Show resolved Hide resolved
beta/src/pages/learn/start-a-new-react-project.md Outdated Show resolved Hide resolved
beta/src/pages/learn/start-a-new-react-project.md Outdated Show resolved Hide resolved
beta/src/pages/learn/start-a-new-react-project.md Outdated Show resolved Hide resolved
beta/src/pages/learn/start-a-new-react-project.md Outdated Show resolved Hide resolved
Updated grammar and fixed minor issues.
@arshadkazmi42
Copy link
Member

@NegiAkash890

Two of the previous comments I have made unresolved and added comment on it. Can you take a look at those.
Those are small changes, seems I wasn't very clear in my comment before.

Let's get those updated and them we can continue with further review.

Thanks

@NegiAkash890
Copy link
Contributor Author

Hi @arshadkazmi42 I am made the necessary changes. Let me know if there any more changes that needs to be done : )

@github-actions
Copy link

github-actions bot commented Feb 19, 2022

Size Changes

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/learn/start-a-new-react-project 57.21 KB (🟡 +1.01 KB) 152.43 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NegiAkash890 I have added review comments to rest of the file.

Once these are fixed, we can get this merged.

beta/src/pages/learn/start-a-new-react-project.md Outdated Show resolved Hide resolved
beta/src/pages/learn/start-a-new-react-project.md Outdated Show resolved Hide resolved
beta/src/pages/learn/start-a-new-react-project.md Outdated Show resolved Hide resolved
beta/src/pages/learn/start-a-new-react-project.md Outdated Show resolved Hide resolved
beta/src/pages/learn/start-a-new-react-project.md Outdated Show resolved Hide resolved
beta/src/pages/learn/start-a-new-react-project.md Outdated Show resolved Hide resolved
beta/src/pages/learn/start-a-new-react-project.md Outdated Show resolved Hide resolved
beta/src/pages/learn/start-a-new-react-project.md Outdated Show resolved Hide resolved
beta/src/pages/learn/start-a-new-react-project.md Outdated Show resolved Hide resolved
@arshadkazmi42
Copy link
Member

@NegiAkash890 any updates? Let me know if any help is required.

Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @NegiAkash890

Let's get this merged 🚀

@arshadkazmi42 arshadkazmi42 merged commit f6e333a into reactjs:main Jun 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1st Review First phase of review beta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants