-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translated Page #169
Translated Page #169
Conversation
Translated start-a-new-react-project.md to Hindi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NegiAkash890 Great start.
I have started the review. Reviewed couple of lines and added some comments. May be you can refer those comments and revisit the whole file one more time.
Also refer this #2 for glossary, which will have details of commonly translated words, the words which we are not translating this will help you with your translations.
Reviewed till line 9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on the fixes.
I have added two more small comments. once those are fixed, I will continue with rest of the file review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the fixes.
Added some more comments till line 50.
Can work on fixing these.
Updated grammar and fixed minor issues.
Two of the previous comments I have made unresolved and added comment on it. Can you take a look at those. Let's get those updated and them we can continue with further review. Thanks |
Hi @arshadkazmi42 I am made the necessary changes. Let me know if there any more changes that needs to be done : ) |
Size Changes📦 Next.js Bundle AnalysisThis analysis was generated by the next.js bundle analysis action 🤖 One Page Changed SizeThe following page changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NegiAkash890 I have added review comments to rest of the file.
Once these are fixed, we can get this merged.
@NegiAkash890 any updates? Let me know if any help is required. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @NegiAkash890
Let's get this merged 🚀
Translated start-a-new-react-project.md to Hindi
Part of #168