-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
conditional rendering page translation #177
conditional rendering page translation #177
Conversation
…om/sanchit36/hi.reactjs.org into sanchit/conditional-rendering-page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work again.
Added review in the file.
Lets close these, then you can continue with further translations
@sanchit36 I have verified the fixes. All looks good. You can continue further with translating the rest of the file |
@arshadkazmi42 I have completed the page, need your review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added review for rest of the changes.
Once these are fixed. these should be go to be merged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work.
Lets get this merged 👍
Translating the conditional rendering page.
Related to #168
Review Progress
? :
)&&
)? :
&&
? :
toif
and variablesI have done till
Conditionally assigning JSX to a variable
.