-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge latest react.dev #224
Conversation
* [Beta] useLayoutEffect API * more * tweak * bla
* [Beta] useEvent -> useEffectEvent * tweak
Proposing a minor grammatical correction on the useEffect API documentation page for triggering an animation example section.
The section under consideration 'Removing unnecessary function dependencies' should use the text 'createOptions function' instead of 'options object' to match the given example correctly. The 'options object' text is being used correctly for the previous section which talks about 'Removing unnecessary object dependencies' however, it must be updated for this section.
The serverUrl variable should be moved inside the component and can be stored as a state to indicate that it's a reactive variable and will be highlighted as such by the linter. Previously the serverUrl variable was stored outside the component function body thus making it a non-reactive value and so it shouldn't have been highlighted by the linter as a useEffect dependency as shown in the concerned example.
* <input> * Fix typo * tweak * separate props * reword * typos * compress * tweaks * Add more * more * shorter * twk * more readable * fix * oops * oops * <textarea> * <progress> * <select>, <progress> * upd * <option> * wip common * wip * more * Fix onSelect desc * index * stub events * events * twk * all events
* Copy over tutorial from old website Fixed up MDX syntax (self-closing `<br>` and `<img>`, and one `style` attribute) * wip * more wip * Move tutorial to be consistent with new beta docs structure * remove HTML comments causing Vercel rendering issues * Fixed all fixme's, minor clarity improvments, updated code links to codesandbox * first half of tutorial re-write draft * Finish tutorial rewrite draft * Fix some formatting issues * Migrate tutorial back to JavaScript to fix Sandpack errors * Fix minor mistakes, formatting, code bugs, clean up images * Fix empty board image size * Fix image size and code highlighting issues * Incorporate feedback from Dan and Sean * edits (wip) * edit * edits * Update beta/src/content/learn/tutorial-tic-tac-toe.md Co-authored-by: Strek <[email protected]> * tweak Co-authored-by: Sophie Alpert <[email protected]> Co-authored-by: Dan Abramov <[email protected]> Co-authored-by: Strek <[email protected]>
* [Beta] Move Reference before Usage * above -> below
* [Beta] APIs -> Reference * oops
* Fix casing for consistency There's 5 instances in this document in which the casing of a file name begins with lower case, which makes it inconsisnent both with the page and the entire tutorial. * Fix improper idiom usage The phrase "most of the times" is incorrect and would only make sense in the context of a larger sentence. The phrase is actually "most of the time" and is used in place of "usually".
Update referencing-values-with-refs.md
Fix: typo in "Animation Event Handler function" example
* Legacy API, Component: fix href for getDerivedStateFromProps * Legacy API, Component: fix href for getDerivedStateFromProps
* fix: url * fix: check if it works * fix * fix * use legacy link * chore: add to vercel.json
* Fix minor grammar mistakes * Apply suggestions from code review --------- Co-authored-by: Sophie Alpert <[email protected]>
* Add site config with domain name * Add <meta> tags for languages * Move legacy redirect out of vercel config This lets us give it a more specific subdomain per lang. * Support sites with no legacy * Fix types * Undo unrelated change
Size Changes📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 🎉 Global Bundle Size Decreased
DetailsThe global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster. Any third party scripts you have added directly to your app using the If you want further insight into what is behind the changes, give @next/bundle-analyzer a try! New Pages AddedThe following pages were added to the bundle from the code in this PR:
Two Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this. |
Catches up the repo to set
main
to the latest react.dev content.There were two docs that were moved and edited that i couldn't resolve conflicts in because they changed quite a bit:
For these I think someone who knows both language should follow up to re-apply and update the translation to these pages based on the latest content.
See this comment for context.