Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

referencing-values-with-refs translated in hindi #229

Merged
merged 6 commits into from
Aug 12, 2023
Merged

referencing-values-with-refs translated in hindi #229

merged 6 commits into from
Aug 12, 2023

Conversation

khizarq313
Copy link
Contributor

English to Hindi: Referencing values with refs #222

Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work.

I have added review till line 208. Let's get these fixes and then we can cotninue further with the review.

To know more about our review process you can refer #23

src/content/learn/referencing-values-with-refs.md Outdated Show resolved Hide resolved
src/content/learn/referencing-values-with-refs.md Outdated Show resolved Hide resolved
src/content/learn/referencing-values-with-refs.md Outdated Show resolved Hide resolved
src/content/learn/referencing-values-with-refs.md Outdated Show resolved Hide resolved
src/content/learn/referencing-values-with-refs.md Outdated Show resolved Hide resolved
src/content/learn/referencing-values-with-refs.md Outdated Show resolved Hide resolved
src/content/learn/referencing-values-with-refs.md Outdated Show resolved Hide resolved
src/content/learn/referencing-values-with-refs.md Outdated Show resolved Hide resolved
src/content/learn/referencing-values-with-refs.md Outdated Show resolved Hide resolved
src/content/learn/referencing-values-with-refs.md Outdated Show resolved Hide resolved
@khizarq313
Copy link
Contributor Author

Great work.

I have added review till line 208. Let's get these fixes and then we can cotninue further with the review.

To know more about our review process you can refer #23

Thanks for the review, I will correct my mistakes as soon as possible!

@khizarq313
Copy link
Contributor Author

I have fixed my translation mistakes, and I am very sorry for my silly mistakes, Please review further so that we get this done as fast as possible. Thank you! @arshadkazmi42 .

@khizarq313 khizarq313 requested a review from arshadkazmi42 June 9, 2023 13:16
Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on the fixes.

I have added some more reviews till line 306.

src/content/learn/referencing-values-with-refs.md Outdated Show resolved Hide resolved
src/content/learn/referencing-values-with-refs.md Outdated Show resolved Hide resolved
src/content/learn/referencing-values-with-refs.md Outdated Show resolved Hide resolved
src/content/learn/referencing-values-with-refs.md Outdated Show resolved Hide resolved
src/content/learn/referencing-values-with-refs.md Outdated Show resolved Hide resolved
src/content/learn/referencing-values-with-refs.md Outdated Show resolved Hide resolved
@khizarq313
Copy link
Contributor Author

Thanks for working on the fixes.

I have added some more reviews till line 306.

Thank You!, I have fixed my mistakes. Lets move further!!

Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this fixes.

I have added review for rest of the file. Once these are fixed we can get this merged.

src/content/learn/referencing-values-with-refs.md Outdated Show resolved Hide resolved
src/content/learn/referencing-values-with-refs.md Outdated Show resolved Hide resolved
src/content/learn/referencing-values-with-refs.md Outdated Show resolved Hide resolved
src/content/learn/referencing-values-with-refs.md Outdated Show resolved Hide resolved
src/content/learn/referencing-values-with-refs.md Outdated Show resolved Hide resolved
src/content/learn/referencing-values-with-refs.md Outdated Show resolved Hide resolved
src/content/learn/referencing-values-with-refs.md Outdated Show resolved Hide resolved
src/content/learn/referencing-values-with-refs.md Outdated Show resolved Hide resolved
src/content/learn/referencing-values-with-refs.md Outdated Show resolved Hide resolved
@khizarq313
Copy link
Contributor Author

khizarq313 commented Aug 12, 2023

Thank you for working on this fixes.

I have added review for rest of the file. Once these are fixed we can get this merged.

Thank you sir!
I have completed all the changes you mentioned above!

Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 💯

Thank you for working on all the fixes.

Lets get this merged 🎉

@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@arshadkazmi42 arshadkazmi42 merged commit 118e6ff into reactjs:main Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1st Review First phase of review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants