Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update manipulating-the-dom-with-refs.md #318

Merged
merged 9 commits into from
Dec 24, 2024

Conversation

MadDevMax
Copy link
Contributor

translated manipulating dom page.

translated manipulating dom page.
Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I have left a few minor comments. Can you take a look at those. Post that we can get this merged.

src/content/learn/manipulating-the-dom-with-refs.md Outdated Show resolved Hide resolved
src/content/learn/manipulating-the-dom-with-refs.md Outdated Show resolved Hide resolved
src/content/learn/manipulating-the-dom-with-refs.md Outdated Show resolved Hide resolved
src/content/learn/manipulating-the-dom-with-refs.md Outdated Show resolved Hide resolved
src/content/learn/manipulating-the-dom-with-refs.md Outdated Show resolved Hide resolved
src/content/learn/manipulating-the-dom-with-refs.md Outdated Show resolved Hide resolved
src/content/learn/manipulating-the-dom-with-refs.md Outdated Show resolved Hide resolved
src/content/learn/manipulating-the-dom-with-refs.md Outdated Show resolved Hide resolved
src/content/learn/manipulating-the-dom-with-refs.md Outdated Show resolved Hide resolved
src/content/learn/manipulating-the-dom-with-refs.md Outdated Show resolved Hide resolved
reverted name translation of example
changed कंपोनेंट्स  to कौम्पोनॅन्टस
also some minor changes
changed कंपोनेंट  to कौम्पोनॅन्ट
Copy link

github-actions bot commented Dec 24, 2024

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just ran the CI and it was throwing the same error. I did some debugging and found there were few heading links were removed which was causing the issue and that is the reason you were not able to commit.

I have left the comments to fix those. please double check if another heading is missing that.

src/content/learn/manipulating-the-dom-with-refs.md Outdated Show resolved Hide resolved
src/content/learn/manipulating-the-dom-with-refs.md Outdated Show resolved Hide resolved
src/content/learn/manipulating-the-dom-with-refs.md Outdated Show resolved Hide resolved
src/content/learn/manipulating-the-dom-with-refs.md Outdated Show resolved Hide resolved
src/content/learn/manipulating-the-dom-with-refs.md Outdated Show resolved Hide resolved
@MadDevMax
Copy link
Contributor Author

@arshadkazmi42 heading issues are fixed now hopefully 🥲

Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@arshadkazmi42 arshadkazmi42 merged commit 10981d8 into reactjs:main Dec 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants