-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update manipulating-the-dom-with-refs.md #318
Update manipulating-the-dom-with-refs.md #318
Conversation
translated manipulating dom page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I have left a few minor comments. Can you take a look at those. Post that we can get this merged.
reverted name translation of example changed कंपोनेंट्स to कौम्पोनॅन्टस also some minor changes
changed कंपोनेंट to कौम्पोनॅन्ट
Size changes📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just ran the CI and it was throwing the same error. I did some debugging and found there were few heading links were removed which was causing the issue and that is the reason you were not able to commit.
I have left the comments to fix those. please double check if another heading is missing that.
Co-authored-by: Arshad Kazmi <[email protected]>
Co-authored-by: Arshad Kazmi <[email protected]>
Co-authored-by: Arshad Kazmi <[email protected]>
@arshadkazmi42 heading issues are fixed now hopefully 🥲 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
translated manipulating dom page.