Update conditional-rendering.md #36
Conversation
|
Deploy preview for hi-reactjs ready! Built with commit 8425d90 |
|
I don't think you need to translate the word 'React'. Refer to #2 . |
|
@kambleaa007 Let me know once you are done with the translation. I will start reviewing after that |
Hi, is this two lines are fine ? |
|
Yes it looks fine. I will a deep check during review, you should follow #2 to check the words we are not translating and the hindi spelling of some complex words |
|
Task Completed, |
|
@kambleaa007 I see you have open another PR #39 which one do you want to get reviewed. |
|
Yeh, i have closed duplicate one |
|
till then, You can assign me other simple task :) |
|
You can pick another page from #1 but let's first close this. There will be some review feedbacks. |
There was a problem hiding this comment.
Good start.
I have reviewed till line 122.
Once you are done with fixing those, I will continue reviewing left over lines.
Also read #23 to know the review process and how to resolve the review feedbacks
| It will render either `<LoginButton />` or `<LogoutButton />` depending on its current state. It will also render a `<Greeting />` from the previous example: | ||
| इस एक्साम्पल में हम बना रहे हे [स्टैटिफुल कम्पोनेनेट ] (/docs/state-and-lifecycle.html#adding-local-state-to-a-class) जिसे बोलते हे `LoginControl`. | ||
|
|
||
| जो करंट स्टेट के हिसाब से `<LoginButton />` या `<LogoutButton />` को रेंडर करेगा वो `<Greeting />` को भी रेंडर करेगा जैसे पिछले एक्साम्पल में बताया था : |
There was a problem hiding this comment.
एक्साम्पल => उदहारण
change this everywhere
There was a problem hiding this comment.
एक्साम्पल=>उदहारणchange this everywhere
no fixed
|
I have resolved, reviewed all changes, |
Nice. Assigned you the page at #1 |
|
I modified all suggested changes :), I thought resolving does auto modifications, what is the status of other contributors 👍 |
|
We would want separate pull requests for different pages, can you create a new PR for hook-intro page? |
|
Some of the feedbacks are left, can you check the unresolved feedback again |
|
There are still few lefts. Go above to this comment Comment |
|
too much overhead so closing this |
|
I don't think you should close the PR. Since you have already raised a new one let's review that. |
No description provided.