-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
translation: SyntheticEvent #66
translation: SyntheticEvent #66
Conversation
Deploy preview for hi-reactjs ready! Built with commit 374b838 |
Sorry, I can't review this. I don't speak Hindi. 😄 |
@bvaughn never too late to learn? ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great start.
I have added comments till line 193. Lets get these closed, then I will start with further reviews.
Also refer #23 to know more about our review process
updated reference-event.md
updated as marked, can go ahead and review further. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good going.
Added review for rest of the file. Once these are fixed, it will be good to go from my end.
Update reference-events.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work. 🎉
For next step there will be second phase of review done by @saranshkataria
post that we will get this merged
-------EDIT-----
Sorry about this. by mistake selected Request Changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work. 🎉
For next step there will be second phase of review done by @saranshkataria
post that we will get this merged
added comments till {#supported-events} |
Update reference-events.md
@ps0305 sorry for the delay, got busy with some covid stuff. Could you please resolve the conflicts so that I can continue with the review? |
|
added a few more comments |
Update reference-events.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added comments till {#mouse-events}
content/docs/reference-events.md
Outdated
|
||
React normalizes events so that they have consistent properties across different browsers. | ||
React इवेंट्स को सामान्य करता है ताकि उनके विभिन्न ब्राउज़रों में सुसंगत गुण हों। |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
सामान्य could be left as is since the translation changes the meaning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
normalizes is different than normal?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant for it to read normalizes, not सामान्य and not नार्मल . Either in english/hindi works
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added comments till {#selection-events}
Update reference-events.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of feedback points and this will be good to merge 🎆
Update reference-events.md
great work 👍 |
Hindi Translation Progress #1
Translation for API Reference => SyntheticEvent