-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hindi translation #8
Conversation
@saranshkataria Can you review this PR. |
@arshadkazmi42 this is a huge one! Will go through it |
getting close, added comments till line 1204 |
Done with the fixes. And added few comments |
content/tutorial/tutorial.md
Outdated
|
||
If you have extra time or want to practice your new React skills, here are some ideas for improvements that you could make to the tic-tac-toe game which are listed in order of increasing difficulty: | ||
यदि आपके पास अतिरिक्त समय है या आप अपने नए React कौशल का अभ्यास करना चाहते हैं, तो यहां सुधार के लिए कुछ विचार दिए गए हैं जो आप टिक-टैक-टो खेल में कर सकते हैं जो कि बढ़ती कठिनाई के क्रम में सूचीबद्ध हैं: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
यदि आपके पास अतिरिक्त समय है incorrect translation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
सूचीबद्ध could be removed altogether?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
यदि आपके पास अतिरिक्त समय है incorrect translation
यदि आपके पास और समय बाकि है या आप अपने नए React स्किल्स का अभ्यास करना चाहते हैं
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good
content/tutorial/tutorial.md
Outdated
4. Add a toggle button that lets you sort the moves in either ascending or descending order. | ||
5. When someone wins, highlight the three squares that caused the win. | ||
6. When no one wins, display a message about the result being a draw. | ||
1. चाल इतिहास सूची में प्रारूप (col, row) में प्रत्येक चाल के लिए स्थान प्रदर्शित करें। |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
प्रारूप could be replaced by something simpler?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe फार्मेट? and reword the sentence a bit accordingly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about this
हर चाल को चाल की हिस्ट्री सूचि में (col, row) फार्मेट में दिखाना।
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool
content/tutorial/tutorial.md
Outdated
2. चाल सूची में वर्तमान में चयनित आइटम को बोल्ड करें। | ||
3. स्क्वायरस को हार्डकोड करने के बजाय दो छोरों का उपयोग करने के लिए रीराइट बोर्ड का उपयोग करें। | ||
4. एक टॉगल बटन जोड़ें जो आपको आरोही या अवरोही क्रम में चालों को क्रमबद्ध करने देता है। | ||
5. जब कोई जीतता है, तो जीत का कारण बनने वाले तीन Square को उजागर करें। |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
revisit bullets altogether once again I guess :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
revisit bullets altogether once again I guess :)
I feel other bullet points looks fine. Changing 4
to this
एक टॉगल बटन डालना जो आपको सभी चालों को असेंडिंग या डिसेंडिंग आर्डर में करने देगा
Any thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool
content/tutorial/tutorial.md
Outdated
|
||
Throughout this tutorial, we touched on React concepts including elements, components, props, and state. For a more detailed explanation of each of these topics, check out [the rest of the documentation](/docs/hello-world.html). To learn more about defining components, check out the [`React.Component` API reference](/docs/react-component.html). | ||
इस ट्यूटोरियल के दौरान, हमने एलिमेंट्स, कौम्पोनॅन्ट, props और state सहित React कॉन्सेप्ट्स पर स्पर्श किया। इनमें से प्रत्येक विषय के अधिक विस्तृत विवरण के लिए, [बाकी दस्तावेज़](/docs/hello-world.html) देखें। घटकों को परिभाषित करने के बारे में अधिक जानने के लिए, [`React.Component` API](/docs/hello-world.html) देखें। |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
घटकों को परिभाषित करने के बारे में अधिक जानने के लिए -> revisit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
घटकों को परिभाषित करने के बारे में अधिक जानने के लिए -> revisit
डिफाइनिंग कौम्पोनॅन्ट के बारे में और जानने के लिए
these are the final set of changes which are needed. We are almost there and this is the longest PR till date! Great work @arshadkazmi42 👏 |
Made few fixes and added comments for rest of them. This PR was created on Feb 15, Almost like 9 months and now we will be getting this merged 🎉 |
Happy to be almost there and sad that it took so long, but we are almost there! 1 more push from your side and we are in! 🎆 |
@saranshkataria Done with the final fixes 👍 |
600 comments and we are in! 🍾 |
Update reference-events.md
Translated whole tutorial page to hindi