Composition vs inheritance #111
Conversation
|
Deploy preview for it-react-org ready! Built with commit 5716e8b |
|
Deploy preview for it-reactjs ready! Built with commit 5716e8b |
Delete file created for reference. It shouldn't have been commited
…pino/it.reactjs.org into composition-vs-inheritance
There was a problem hiding this comment.
Hi @GCrispino, thank you for this!
A couple of things:
-
regarding CodePen, I disagree with having personal CodePens. I'd rather keep the ownership of the examples to @gaearon or perhaps even better, I'd host the examples locally in source control... which would allow a more fine-grained translation as well.
You can see an example of that in my last PR Translation of the page "Conditional rendering" #110For example:
https://github.com/reactjs/it.reactjs.org/pull/110/files#diff-dc0f06d21d31ca223b3a5a1d26a98419which is referenced here:
https://github.com/reactjs/it.reactjs.org/pull/110/files#diff-0e411735995c77155dda4dd7b4f7d969R45Does it make sense to you?
-
Don't get me wrong, I am sure that your Italian is better than my Portuguese 😄 but honestly, since we are all investing time and effort in this, in order to give back to a community, I believe that the quality should be better than this (cc @LucaBlackDragon for an additional pair of eyes), you'll see my suggestions later when I'll finish the review
-
You forgot to translate: https://github.com/GCrispino/it.reactjs.org/blob/composition-vs-inheritance/content/docs/nav.yml#L35 and I am not sure if there are more references to the title
|
@deblasis No worries! I know that my Italian has a lot to improve, and if you think that it's better for a native speaker to do it rather than me, that's no problem 😃. Thank you! |
|
Hi @GCrispino, so... I had a look at your translation, started reviewing it but I gave up after noticing that I was rewriting it 😞, please have a look at the first suggestions to have an idea. I really appreciate your attempt but I would abandon this PR and make the page available for other translators, if @LucaBlackDragon agrees with me of course. Sorry for not getting back to you earlier, I hope you didn't spend more time on this meanwhile. |
|
@deblasis no problem! Thank you so much for your feedback, and sorry to waste your time. |
|
No worries @GCrispino, thanks anyways! |
|
I'm sorry to reply so late, this is going to be a busy week for me. I'll try to focus on reviewing PRs... Anyway I agree with @deblasis, but thanks again for the effort @GCrispino! |
References #25.
I believe the translation is fair. I just have some questions:
<Dialog />were left untranslated but<WelcomeDialog />, for example, was translated to<DialogBenvenuti />. I'm open to suggestions, though, if you think this is not right.