Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translation of the page "Lists and Keys" #112

Merged
merged 13 commits into from
Mar 1, 2019
Merged

Translation of the page "Lists and Keys" #112

merged 13 commits into from
Mar 1, 2019

Conversation

lssmn
Copy link
Collaborator

@lssmn lssmn commented Feb 25, 2019

Fixes #22

@lssmn lssmn added needs +1 Needs an approval before merging (not from the author) 💪 long page - more than 100 lines Looooong page, expect delays! labels Feb 25, 2019
@lssmn lssmn requested a review from deblasis February 25, 2019 09:23
@netlify
Copy link

netlify bot commented Feb 25, 2019 •
edited
Loading

Deploy preview for it-reactjs ready!

Built with commit 795d82e

https://deploy-preview-112--it-reactjs.netlify.com

@netlify
Copy link

netlify bot commented Feb 25, 2019 •
edited
Loading

Deploy preview for it-react-org ready!

Built with commit 795d82e

https://deploy-preview-112--it-react-org.netlify.com

@lssmn lssmn added the 🏗️ Work in progress Work in progress label Feb 25, 2019
@lssmn
Copy link
Collaborator Author

lssmn commented Feb 25, 2019

@deblasis @LucaBlackDragon I've seen #110 and was thinking to translate the CodePen code samples in this one too. Putting it in "work in progress" but feel free to review 👍

@deblasis
Copy link
Collaborator

Hey @lssmn! I thought you might want to have a peek at #113 regarding embedding the code samples.
CodePen currently doesn't allow uploading CSS, CodeSandbox does though.
Apparently people started migrating code samples mainstream too so.. we are ahead of schedule in a way 😜

cc @LucaBlackDragon

@lssmn
Copy link
Collaborator Author

lssmn commented Feb 26, 2019

Great! Yeah I've seen that you mentioned reactjs/react.dev#913
Will update this too 👌

@lssmn lssmn added ✔ translated and removed 🏗️ Work in progress Work in progress 💪 long page - more than 100 lines Looooong page, expect delays! labels Feb 26, 2019
deblasis
deblasis requested changes Feb 27, 2019
View reviewed changes
content/docs/lists-and-keys.md Outdated Show resolved Hide resolved
content/docs/lists-and-keys.md Outdated Show resolved Hide resolved
content/docs/lists-and-keys.md Outdated Show resolved Hide resolved
content/docs/lists-and-keys.md Outdated Show resolved Hide resolved
content/docs/lists-and-keys.md Outdated Show resolved Hide resolved
content/docs/lists-and-keys.md Outdated Show resolved Hide resolved
@deblasis
Copy link
Collaborator

deblasis commented Mar 1, 2019

Ciao @lssmn ! I saw you commented back but I think you forgot to approve the suggestions 😄
Would you mind having a look?

@lssmn
Copy link
Collaborator Author

lssmn commented Mar 1, 2019 •
edited
Loading

Hey @deblasis I was outside of the country and commented from my mobile 😅
I have approved the suggestions and resolved the conflicts.
Feel free to have a final review and merge 🎉

@deblasis deblasis removed the needs +1 Needs an approval before merging (not from the author) label Mar 1, 2019
@deblasis deblasis merged commit 27140ef into reactjs:master Mar 1, 2019
@deblasis
Copy link
Collaborator

deblasis commented Mar 1, 2019

Hey @deblasis I was outside of the country and commented from my mobile 😅
I have approved the suggestions and resolved the conflicts.
Feel free to have a final review and merge 🎉

Oh I see!
All good, merged! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deblasis deblasis deblasis approved these changes

@LucaBlackDragon LucaBlackDragon Awaiting requested review from LucaBlackDragon

Assignees
No one assigned
Labels
✔ translated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lssmn @deblasis @LucaBlackDragon