Sync with react.dev @ 9967ded3 #48
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems like these localhost references were being stripped out anyway, so this isn't a bugfix but just a small cleanup.
This PR adds a new Rules of React reference section that covers the major rules that help developers author idiomatic React apps. --------- Co-authored-by: Sathya Gunasekaran <[email protected]>
Small change to match the sidebar order.
Co-authored-by: Sebastian Silbermann <[email protected]> Co-authored-by: Allison Strandberg <[email protected]>
This example contains a list of person objects, but only the first 3 have id properties. This appears to be a mistake; in the next use of the list all 5 person objects have this property, but it is not changed as part of an instructive exercise. This change makes the final two with objects consistent with the remainder of the list.
`an text area` -> `a text area` `an discussion` -> `a discussion`
…6728) Signed-off-by: Faridul Islam <[email protected]>
Noticed this randomly and couldn't unsee it, so here's a quick PR to fix.
* change isOpen variable in TopNav component to isMenuOpen to differentiate from isOpen props in Search component change setIsOpen to setIsMenuOpen in TopNav component * move initialization of ShowSearch state to top-level of TopNav component organize hook initializations in TopNav component: useState, useRef, useRouter * remove initialYScroll prop from DocSearchModal component to fix search functionality on ios devices
* Add docs for onCaughtError and onUncaughtError * Updates from feedback
Note that this component is not actually expandable and the ref got likely unused when that was removed
* in \[errorCode\].tsx, wrapped parsedContent in a div and applied styling of white-space: pre-wrap to preserve whitespace and break on newline chars * updated styling to tailwind class
Tickets are sold out, update the text.
* API docs for useDeferredValue's initialValue Updates the API docs for `useDeferredValue` to include the `initialValue` option, added in facebook/react#27500. This feature is slated for release in React 19. * Add docs for onCaughtError and onUncaughtError (#6742) * Add docs for onCaughtError and onUncaughtError * Updates from feedback * Add canary info, simplify a bit --------- Co-authored-by: Ricky <[email protected]>
* Add documentation for ref cleanup functions * Contain changes within canary block
* Add new article "Translations" * Add "languages" button in TopNav * Add link to English (main) site * Split deployedTranslations into multiple lines * Fix build error regarding types * Address some review comments - deployedTranslations => finishedTranslations - showTranslated => progress - English fixes * Update src/content/community/translations.md Co-authored-by: Ricky <[email protected]> * Update src/content/community/translations.md --------- Co-authored-by: Ricky <[email protected]>
Thanks to @SAWARATSUKI for updating the logo!
Change the tense of "build" to "building".
* Update synchronizing-with-effects.md Currently documentation says: By default, your Effect will run after every render. Which is in contrast with another section of the same page where it says: Effects run at the end of a commit after the screen updates * Update src/content/learn/synchronizing-with-effects.md --------- Co-authored-by: Ricky <[email protected]>
* Fix #6854: node.js version upgrade * Fix #6854: node.js version update
Co-authored-by: Rajat Jindal <[email protected]>
* Update team.md: Jason Bonta * Update src/content/community/team.md Lauren's suggestion Co-authored-by: lauren <[email protected]> --------- Co-authored-by: lauren <[email protected]>
* Add initial skeleton * Scaffold compiler docs structure * Braindump for getting started * Add intro * tweaks * add experimental tag * flesh more out of index page * flesh out installation * add installation intro * update install instrs * add section on eslint plugin * reorg * add incremental guide * [debugging] Add section about devtools badge * [debugging] Add section about using logger * Update next.js instructions * reporting issues * [debugging] Add section on useEffect over firing * [debugging] Add section about conditional hook call * Latest updates * Remove ununsed reference pages * adding extra context for Remix --------- Co-authored-by: Sathya Gunasekaran <[email protected]> Co-authored-by: Lauren Tan <[email protected]> Co-authored-by: Jason Bonta <[email protected]>
Using "off", "warn", "error" has been supported for many years now - I think this helps improve the readability :) I completely forgot what rule: 2 meant - had to find it at https://eslint.org/docs/latest/use/configure/rules
Removed ; as it's unnecessary in jsx component
Front end nation is covering a full track of React talks including speakers such as: * Kent C Dodds * Sara Vieira * Tejas Kumar
Size changes📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
| Page | Size (compressed) |
|---|---|
global |
104.15 KB (🟡 +259 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Five Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
| Page | Size (compressed) | First Load |
|---|---|---|
/404 |
81.12 KB (🟡 +1.37 KB) |
185.27 KB |
/500 |
81.12 KB (🟡 +1.37 KB) |
185.27 KB |
/[[...markdownPath]] |
82.96 KB (🟡 +1.52 KB) |
187.11 KB |
/errors |
81.33 KB (🟡 +1.4 KB) |
185.48 KB |
/errors/[errorCode] |
81.3 KB (🟡 +1.41 KB) |
185.46 KB |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically generated.
Merge changes from react.dev at 9967ded
DO NOT SQUASH MERGE THIS PULL REQUEST!
Doing so will "erase" the commits from main and cause them to show up as conflicts the next time we merge.