Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fixed] stacked/nested modals have focus lost in Safari #934

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

s-robertson
Copy link

If the keydown event within the currently-open, nested modal is propagated, Safari will toggle focus between the parent modal's focusable elements instead.

Fixes #801.

Acceptance Checklist:

  • The commit message follows the guidelines in CONTRIBUTING.md.
  • Documentation (README.md) and examples have been updated as needed.
  • If this is a code change, a spec testing the functionality has been added.
  • If the commit message has [changed] or [removed], there is an upgrade path above.

Fixes reactjs#801

If the `keydown` event within the currently-open, nested modal is propagated, Safari will toggle focus between the parent modal's focusable elements instead.
@marianavin
Copy link

marianavin commented Dec 4, 2023

Hey there - what's the current status of this task? It's currently blocking the development in my team. Would you be able to say if it's going to be merged soon? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stacked/nested modals have focus lost in Safari
2 participants