[changed] add stopPropagation at handleOverlayOnClick #940
Conversation
src/components/ModalPortal.js
Outdated
| @@ -285,6 +285,8 @@ export default class ModalPortal extends Component { | |||
| }; | |||
|
|
|||
| handleOverlayOnClick = event => { | |||
| event.stopPropagation(); | |||
There was a problem hiding this comment.
I came across this pull request as my events aren't propagating right now when I want them to (I'm doing something wrong in my app). My scenario is that I have a transparent overlay and shouldCloseOnOverlayClick is set. I want the modal to close and underlying control to be clicked.
I don't think that event.stopPropagation() should always happen; it should be opt-in (or a setting to control the behavior). With this change, I believe it's possible to break existing use of react-modal that relies on this behavior.
There was a problem hiding this comment.
Thanks for the review @smcenlly. I will take a look
There was a problem hiding this comment.
We can add the stopPropagation there...we need to be careful here to only stop if the event target is the overlay.
There was a problem hiding this comment.
I am checking this, in this commit: 4dd8ee3
There was a problem hiding this comment.
Muito bem...um potiguar por aqui!!
I think we are close to get this done...can this event not be related to the overlay? I'm not sure if that is a valid case, but it would be nice to check it.
There was a problem hiding this comment.
This needs to be merged and released if this allows handling overlay click events.
|
This needs to be merged and released if this allows handling overlay click events. |
Fixes #939.
Changes proposed:
Upgrade Path (for changed or removed APIs):
Acceptance Checklist:
CONTRIBUTING.md.