Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate Challenges.tsx #101

Merged
merged 1 commit into from
Nov 24, 2024
Merged

Translate Challenges.tsx #101

merged 1 commit into from
Nov 24, 2024

Conversation

rammba
Copy link
Collaborator

@rammba rammba commented Nov 20, 2024

Hello @lxmarinkovic, I've created #100 and realized that pipeline fails when these changes are on the same line. I didn't want to have multiple unnecessary commits on main branch and here is the new PR.

@rammba rammba requested a review from lxmarinkovic November 20, 2024 22:06
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Five Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 104.85 KB (🟡 +15 B) 209.15 KB
/500 104.85 KB (🟡 +15 B) 209.15 KB
/[[...markdownPath]] 106.7 KB (🟡 +15 B) 211 KB
/errors 105.06 KB (🟡 +15 B) 209.36 KB
/errors/[errorCode] 105.04 KB (🟡 +15 B) 209.34 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link
Collaborator

@lxmarinkovic lxmarinkovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 🚀

@lxmarinkovic lxmarinkovic merged commit d0395d1 into main Nov 24, 2024
3 checks passed
@lxmarinkovic lxmarinkovic deleted the features/challenges branch November 24, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants