Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add React to an Existing Project #80

Merged
merged 7 commits into from
Mar 25, 2024
Merged

Conversation

srikanth-kandi
Copy link
Collaborator

Hello @g-savitha, @gsteja2307 and @vamsikrishnareddybevara

I have translated the entire page of Add React to an Existing Project to Telugu by following the Telugu Glossary and other guidelines provided.

Please carefully review the translated content, and merge it ASAP because I'm eager to translate other pages also but as mentioned in #1 "Please take only one page at a time".

Merging this PR will close #10

Thank you :)

@srikanth-kandi
Copy link
Collaborator Author

Please add me as one of the maintainers, I have experience with React and have completed many projects using it.
Check them on my profile @srikanth-kandi and my certifications mentioned in LinkedIn

@g-savitha @gsteja2307

According to the guidelines about Adding a Maintainer mentioned in translations.react.dev, if any of the maintainers like @vamsikrishnareddybevara isn't active on this repository for the last 3 months or so. They need to be replaced by others.

So I hope you consider adding me as another maintainer for this repository.

@srikanth-kandi
Copy link
Collaborator Author

Hello @g-savitha please review this pull request, as I'm also working on another page, so if PR was merged I can send another pull request of that translated page.

@gsteja2307
Copy link
Contributor

gsteja2307 commented Jan 19, 2024

Hello @g-savitha, @gsteja2307 and @vamsikrishnareddybevara

I have translated the entire page of Add React to an Existing Project to Telugu by following the Telugu Glossary and other guidelines provided.

Please carefully review the translated content, and merge it ASAP because I'm eager to translate other pages also but as mentioned in #1 "Please take only one page at a time".

Merging this PR will close #10

Thank you :)

Appreciate your work on the Telugu translation of this page. I've noticed certain phrases seem directly translated, potentially losing the intended meaning in Telugu. Please recheck for grammatical and contextual accuracy. Ensuring that the translation accurately conveys the original message and reads naturally in Telugu is crucial.

Detailed proofreading would be very helpful. Thanks!

I've provided some examples in the PR review. Please ensure a comprehensive check before finalizing your changes. Additionally, be cautious with text in square brackets, typically links, to preserve context. If feasible, also update the linked titles for clarity and relevance.

As referring to the [uk.react.dev](https://uk.react.dev/learn/add-react-to-an-existing-project), the comment sections of the code blocks are also translated into their native language. So following the same trend I updated the codeblock comments to Telugu for our repo.
Copy link
Contributor

@g-savitha g-savitha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments need not to be updated, as these will not be shown to end user.

src/content/learn/add-react-to-an-existing-project.md Outdated Show resolved Hide resolved
src/content/learn/add-react-to-an-existing-project.md Outdated Show resolved Hide resolved
src/content/learn/add-react-to-an-existing-project.md Outdated Show resolved Hide resolved
src/content/learn/add-react-to-an-existing-project.md Outdated Show resolved Hide resolved
src/content/learn/add-react-to-an-existing-project.md Outdated Show resolved Hide resolved
src/content/learn/add-react-to-an-existing-project.md Outdated Show resolved Hide resolved
src/content/learn/add-react-to-an-existing-project.md Outdated Show resolved Hide resolved
src/content/learn/add-react-to-an-existing-project.md Outdated Show resolved Hide resolved
src/content/learn/add-react-to-an-existing-project.md Outdated Show resolved Hide resolved
src/content/learn/add-react-to-an-existing-project.md Outdated Show resolved Hide resolved
@srikanth-kandi
Copy link
Collaborator Author

Comments need not to be updated, as these will not be shown to end user.

But as mentioned in this style-guide Leave text in code blocks untranslated except for comments

So if we translate the comments of code blocks to Telugu it can help easily understand the purpose of that code block for a newbie.

@g-savitha

@srikanth-kandi
Copy link
Collaborator Author

Can anyone review this PR

@g-savitha @gsteja2307

@srikanth-kandi
Copy link
Collaborator Author

Please add me as one of the maintainers, I have experience with React and have completed many projects using it. Check them on my profile @srikanth-kandi and my certifications mentioned in LinkedIn

@g-savitha @gsteja2307

According to the guidelines about Adding a Maintainer mentioned in translations.react.dev, if any of the maintainers like @vamsikrishnareddybevara isn't active on this repository for the last 3 months or so. They need to be replaced by others.

So I hope you consider adding me as another maintainer for this repository.

You guys didn't consider making me a maintainer, and you are also not responding to the contributions.
Consider responding to this repository updates by sparing at least some time a day 🙏

@g-savitha @gsteja2307

@srikanth-kandi srikanth-kandi mentioned this pull request Jan 29, 2024
@srikanth-kandi
Copy link
Collaborator Author

Hey @g-savitha and @gsteja2307

Please review this and my existing pull requests, I requested you make me a maintainer on #1. Otherwise, add some other maintainers you know who will actively monitor the contributions on this repository.

Waiting for your response.

Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@srikanth-kandi srikanth-kandi removed the request for review from rickhanlonii March 25, 2024 15:28
@srikanth-kandi srikanth-kandi merged commit 20eb925 into reactjs:main Mar 25, 2024
3 checks passed
@srikanth-kandi srikanth-kandi changed the title Add React to an Existing Project page translated to Telugu Add React to an Existing Project Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add React to an Existing Project
3 participants