Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tamil Language #268

Merged
merged 7 commits into from
May 18, 2023
Merged

Add Tamil Language #268

merged 7 commits into from
May 18, 2023

Conversation

CarreraPHP
Copy link
Contributor

@CarreraPHP CarreraPHP commented Apr 25, 2023

@gaearon,

As discussed with you earlier, I have formed a small team of passionate react developers who can speak, read & write in Tamil fluently. We don't have translation or tech writing experience before.

But, we do have the necessity to have the documentation in our Language and it would greatly help us in the training process.

Regards,
Yogesh Surendran

@CarreraPHP CarreraPHP requested a review from tesseralis as a code owner April 25, 2023 11:10
@vercel
Copy link

vercel bot commented Apr 25, 2023

@CarreraPHP is attempting to deploy a commit to the Meta Open Source Team on Vercel.

A member of the Team first needs to authorize it.

Meyyamma and others added 3 commits April 26, 2023 11:19
update tamil maintainers list
Update tamil maintainers list
@CarreraPHP
Copy link
Contributor Author

@tesseralis is there anything left to do from our side?

Copy link
Member

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a part of fixing the permission sync process, we've changed how we track languages — please see 63a10c4.
Could you please update this PR:

  • Rebase on top of latest main, and add the language to lang/langs.json instead
  • Include the list of maintainers into the PR comment body instead

Thank you, and sorry for the churn.

@CarreraPHP
Copy link
Contributor Author

@gaearon , have done the changes needed.

Copy link
Contributor Author

@CarreraPHP CarreraPHP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have removed the newly added ta.json file and updated the langs.json file

@gaearon gaearon merged commit b4766d6 into reactjs:main May 18, 2023
@gaearon
Copy link
Member

gaearon commented May 18, 2023

reactjs/ta.react.dev#1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants