Sync with react.dev @ e85b71de #488
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Make bundle analysis workflow less fragile * Use sticky comment action
The actual dom nodes that are siblings are the h1 and article nodes
* Add key param to createPortal reference * Update createPortal.md * Update createPortal.md * Update createPortal.md --------- Co-authored-by: dan <[email protected]>
The sentence reads: In this solution, two separate conditions are used to insert a space between then name and the importance label. It should read: In this solution, two separate conditions are used to insert a space between the name and the importance label.
See facebook/react#26761 for more context.
This reverts commit aa88d8a.
* Revert "Revert "Canaries blog post"" This reverts commit 9a865fd. * words --------- Co-authored-by: Sophie Alpert <[email protected]>
…de.js stream) (#6001)
…(#6003) Mounting with Suspense and Offscreen can happen multiple times. This removes some wording that implies a that effects / lifecycle hooks only happen on first mount.
Otherwise the address is being offset to the right when the refresh icon is not displayed
… (#6026) * Add accessibility note to interactivity section in the new React docs * Add a11y note to Responding to Events section * Update responding-to-events.md --------- Co-authored-by: dan <[email protected]>
* Upgrade React and Next * Fix bug in useNestedScrollLock I guess refs get disconnected before passive effect cleanup runs. useLayoutEffect would also fix it but maybe this is better.
* Fix manipulating-the-dom-with-refs * Update manipulating-the-dom-with-refs.md --------- Co-authored-by: dan <[email protected]>
corrected links
…llback doesn't seem to be accurate. (#6207) * Update useEffect.md * Update src/content/reference/react/useEffect.md --------- Co-authored-by: Sophie Alpert <[email protected]>
* delete unused useState import * add word to equalize challenge and solutions texts * Refactor some texts * Apply suggestions from code review --------- Co-authored-by: Sophie Alpert <[email protected]>
* Remove pitfall and update Next link * Fix other beta link --------- Co-authored-by: Luna Wei <[email protected]>
Co-authored-by: Luna <[email protected]>
* Update react-labs-what-we-have-been-working-on-june-2022.md * Update react-labs-what-we-have-been-working-on-june-2022.md
…5836) * Update referencing-values-with-refs.md * Update src/content/learn/referencing-values-with-refs.md
Maybe it's debatable whether we want to link to canary APIs in other pages but I feel like here it's more useful than not.
Co-authored-by: Matt Carroll <[email protected]>
* Explain limitations of useSyncExternalStore with concurrency Doesn't seem like we have this noted anywhere. * Pull out example to code block
* Upgrade react-collapsed * 4.0.4 --------- Co-authored-by: Rogin Farrer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically generated.
Merge changes from react.dev at e85b71d
The following files have conflicts and may need new translations:
Please fix the conflicts by pushing new commits to this pull request, either by editing the files directly on GitHub or by checking out this branch.
DO NOT SQUASH MERGE THIS PULL REQUEST!
Doing so will "erase" the commits from main and cause them to show up as conflicts the next time we merge.