-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync with react.dev @ a8790ca8 #492
Conversation
* Make bundle analysis workflow less fragile * Use sticky comment action
The actual dom nodes that are siblings are the h1 and article nodes
* Add key param to createPortal reference * Update createPortal.md * Update createPortal.md * Update createPortal.md --------- Co-authored-by: dan <[email protected]>
The sentence reads: In this solution, two separate conditions are used to insert a space between then name and the importance label. It should read: In this solution, two separate conditions are used to insert a space between the name and the importance label.
See facebook/react#26761 for more context.
This reverts commit aa88d8a.
* Revert "Revert "Canaries blog post"" This reverts commit 9a865fd. * words --------- Co-authored-by: Sophie Alpert <[email protected]>
…de.js stream) (#6001)
…(#6003) Mounting with Suspense and Offscreen can happen multiple times. This removes some wording that implies a that effects / lifecycle hooks only happen on first mount.
Otherwise the address is being offset to the right when the refresh icon is not displayed
… (#6026) * Add accessibility note to interactivity section in the new React docs * Add a11y note to Responding to Events section * Update responding-to-events.md --------- Co-authored-by: dan <[email protected]>
* Upgrade React and Next * Fix bug in useNestedScrollLock I guess refs get disconnected before passive effect cleanup runs. useLayoutEffect would also fix it but maybe this is better.
* Fix manipulating-the-dom-with-refs * Update manipulating-the-dom-with-refs.md --------- Co-authored-by: dan <[email protected]>
* Warn about low entropy in taintUniqueValue.md * Update src/content/reference/react/experimental_taintUniqueValue.md Co-authored-by: Jan Kassens <[email protected]> --------- Co-authored-by: Jan Kassens <[email protected]>
Add useFormState reference
* Add useFormState reference * Matt's suggestions for useFormState reference * Incorporated PR feedback for useFormState
Co-authored-by: Nikhil Gupta <[email protected]>
Co-authored-by: Luna <[email protected]>
* Add useOptimistic API reference documentation * Fix title * Add working exmaple from form and updadd parameters * Add updates to useOptimistic * Add updates to useOptimistic * Add updates to useOptimistic --------- Co-authored-by: Matt Carroll <[email protected]>
Google uses this on many of our API doc pages and it's not a good snippet. Only put this on the homepage but leave the og:description and twitter:description.
* Adds landing page for reference section.) * Updated hyperlinks. * Fixes Legacy APIs link. * Removes canary image from heading.
Co-authored-by: Sophie Alpert <[email protected]> Co-authored-by: Luna Wei <[email protected]>
Co-authored-by: Soichiro Miki <[email protected]> Co-authored-by: David McCabe <[email protected]> Co-authored-by: Luna Wei <[email protected]>
* Edits for new "use client" content * Apply suggestions from code review Co-authored-by: Luna <[email protected]> --------- Co-authored-by: Luna <[email protected]>
Size changes📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
Page | Size (compressed) |
---|---|
global |
103.74 KB (🟡 +10.12 KB) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Four Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
Page | Size (compressed) | First Load |
---|---|---|
/404 |
77.33 KB (🟡 +1.33 KB) |
181.07 KB |
/500 |
77.32 KB (🟡 +1.33 KB) |
181.07 KB |
/[[...markdownPath]] |
78.92 KB (🟡 +1.5 KB) |
182.66 KB |
/_error |
182 B (🟢 -12 B) |
103.92 KB |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link
is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and files in the description may be checked as well, I think
This PR was automatically generated.
Merge changes from react.dev at a8790ca
The following files have conflicts and may need new translations:
Please fix the conflicts by pushing new commits to this pull request, either by editing the files directly on GitHub or by checking out this branch.
DO NOT SQUASH MERGE THIS PULL REQUEST!
Doing so will "erase" the commits from main and cause them to show up as conflicts the next time we merge.