Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finished translation of "Passing Props to a Component" page #495

Merged

Conversation

ltlaitoff
Copy link
Contributor

I never received a response about whether I can translate this article under my comment, but I decided to translate it.

This repository version was missing one change from the main one, so I made a sync commit.

Copy link

github-actions bot commented Nov 7, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@@ -983,13 +983,13 @@ h1 {

<Hint>

Any JSX you put inside of a component's tag will be passed as the `children` prop to that component.
Будь-який JSX, який ви поміщаєте всередину тегу компонента, буде переданий як властивість `children` цьому компоненту.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Будь-який JSX, який ви поміщаєте всередину тегу компонента, буде переданий як властивість `children` цьому компоненту.
Будь-який JSX, який ви розміщуєте всередині тегу компонента, буде переданий як властивість `children` цьому компоненту.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw, either проп or властивість should be used. there are a few places including this one with властивість instead of проп

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also i have a doubt about using JSX in Ukrainian without код or any other detail, as it looks like 'calque', e.g.:
Передати JSX
Передати JSX-код
I think it's up for discussion

src/content/learn/passing-props-to-a-component.md Outdated Show resolved Hide resolved
src/content/learn/passing-props-to-a-component.md Outdated Show resolved Hide resolved
src/content/learn/passing-props-to-a-component.md Outdated Show resolved Hide resolved
src/content/learn/passing-props-to-a-component.md Outdated Show resolved Hide resolved
src/content/learn/passing-props-to-a-component.md Outdated Show resolved Hide resolved
src/content/learn/passing-props-to-a-component.md Outdated Show resolved Hide resolved
src/content/learn/passing-props-to-a-component.md Outdated Show resolved Hide resolved
src/content/learn/passing-props-to-a-component.md Outdated Show resolved Hide resolved
src/content/learn/passing-props-to-a-component.md Outdated Show resolved Hide resolved
@alinkedd
Copy link
Collaborator

alinkedd commented Nov 8, 2023

btw, the main branch was updated recently, so maybe sync commit is not required anymore and may be omitted in case of rebase

Copy link

github-actions bot commented Nov 8, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@ltlaitoff
Copy link
Contributor Author

@alinkedd Thank you for your corrections! 😉

I committed most of them using your changes, others are in commit 2162acd

I also performed a rebase on the main branch, so now there is no commit sync

Now, there are only a few disputed points left to resolve

src/content/learn/passing-props-to-a-component.md Outdated Show resolved Hide resolved
src/content/learn/passing-props-to-a-component.md Outdated Show resolved Hide resolved
src/content/learn/passing-props-to-a-component.md Outdated Show resolved Hide resolved
src/content/learn/passing-props-to-a-component.md Outdated Show resolved Hide resolved
src/content/learn/passing-props-to-a-component.md Outdated Show resolved Hide resolved
src/content/learn/passing-props-to-a-component.md Outdated Show resolved Hide resolved
src/content/learn/passing-props-to-a-component.md Outdated Show resolved Hide resolved
src/content/learn/passing-props-to-a-component.md Outdated Show resolved Hide resolved
src/content/learn/passing-props-to-a-component.md Outdated Show resolved Hide resolved
src/content/learn/passing-props-to-a-component.md Outdated Show resolved Hide resolved
@bkatsevych bkatsevych merged commit f618fbd into reactjs:main Nov 9, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants