Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(cn): improve learn/you-might-need-an-effect translation #1338

Merged
merged 1 commit into from
Oct 8, 2023

Conversation

ZhaoTim
Copy link
Contributor

@ZhaoTim ZhaoTim commented Oct 7, 2023

原文:

In the Buy button click event handler, you know exactly what happened. By the time an Effect runs, you don’t know what the user did (for example, which button was clicked).

我觉得原文是想强调:在事件的回调函数里,我们自然地知晓发生了什么,因为我们查看这个事件回调函数由哪个事件触发的就一目了然。但是如果此时有一个Effect运行了,我们无法根据这个Effect来推断出,用户到底做了什么。

线上的翻译我读上去总觉得有点别扭,感觉没有表达出英文想表达的~

@github-actions
Copy link

github-actions bot commented Oct 7, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@awxiaoxian2020 awxiaoxian2020 changed the title Update you-might-not-need-an-effect.md feat: improve translation Oct 7, 2023
Copy link
Collaborator

@awxiaoxian2020 awxiaoxian2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@awxiaoxian2020 awxiaoxian2020 requested a review from Yucohny October 7, 2023 23:24
@awxiaoxian2020 awxiaoxian2020 changed the title feat: improve translation feat: improve translations Oct 7, 2023
@Yucohny Yucohny changed the title feat: improve translations docs(cn): improve learn/you-might-need-an-effect translation Oct 8, 2023
@Yucohny Yucohny merged commit 1ec4e42 into reactjs:main Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants