Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(cn): improve learn/reusing-logic-with-custom-hooks translation #1645

Merged
merged 1 commit into from
Dec 21, 2024

Conversation

ZhaoTim
Copy link
Contributor

@ZhaoTim ZhaoTim commented Dec 21, 2024

现在的翻译并不通顺,阅读原文后,发现英文版本是:

There is a number of edge cases it doesn’t consider. For example, it assumes that when the component mounts, isOnline is already true, but this may be wrong if the network already went offline.

  1. assume我觉得翻译成认为读起来更通顺。
  2. 增加了主语,否则读起来真的很迷惑。

Copy link

vercel bot commented Dec 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zh-hans-react-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 21, 2024 4:31am

Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link
Collaborator

@loveloki loveloki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@loveloki loveloki merged commit 933106a into reactjs:main Dec 21, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants