Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: translate keeping-components-pure #414

Merged
merged 50 commits into from
Oct 16, 2023

Conversation

yangvi0158
Copy link
Contributor

Hi, Please let me know if any problem I need to fix.
Thank you :)

@neighborhood999
Copy link
Member

Hi, Please let me know if any problem I need to fix. Thank you :)

Hi @viboloveyou12,

First, thank you for your contribution. I found @rccj claimed this document to translate😅, but it's okay, and don't worry. If you want to contribute other documents don't forget to leave a comment on #260, I will update the list to avoid this situation.

@yangvi0158
Copy link
Contributor Author

Oh, I'm so sorry that I didn't notice the issue!
Thank you for reminding me of this, I'll definitely check it and leave a comment next time.🙏

@rccj
Copy link

rccj commented Sep 11, 2023

@neighborhood999 hi, I just noticed this mention now. Please remove me so that @viboloveyou12 can complete this contribution without any concerns. Thank you 🙏. I'm sorry I couldn't complete this task.

Copy link
Member

@neighborhood999 neighborhood999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @viboloveyou12 ,

Thank you for your hard work 🙌, I gave you some suggestions and you can take a look.

Let me know if you have any questions about my suggestions; most translation looks good to me; For some terms we can reserve, you can check Glossary.

src/content/learn/keeping-components-pure.md Outdated Show resolved Hide resolved
src/content/learn/keeping-components-pure.md Outdated Show resolved Hide resolved
src/content/learn/keeping-components-pure.md Outdated Show resolved Hide resolved
src/content/learn/keeping-components-pure.md Outdated Show resolved Hide resolved
src/content/learn/keeping-components-pure.md Outdated Show resolved Hide resolved
src/content/learn/keeping-components-pure.md Outdated Show resolved Hide resolved
src/content/learn/keeping-components-pure.md Outdated Show resolved Hide resolved
src/content/learn/keeping-components-pure.md Outdated Show resolved Hide resolved
src/content/learn/keeping-components-pure.md Outdated Show resolved Hide resolved
src/content/learn/keeping-components-pure.md Outdated Show resolved Hide resolved
@yangvi0158
Copy link
Contributor Author

Hi @neighborhood999 ,
Thanks for your review and suggestions.
I've modified a new version, if there is anything that can be improved please let me know.

Thank you:)

Copy link
Member

@neighborhood999 neighborhood999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank @viboloveyou12 for helping, most look great to me.

src/content/learn/keeping-components-pure.md Outdated Show resolved Hide resolved
src/content/learn/keeping-components-pure.md Outdated Show resolved Hide resolved
src/content/learn/keeping-components-pure.md Outdated Show resolved Hide resolved
src/content/learn/keeping-components-pure.md Outdated Show resolved Hide resolved
src/content/learn/keeping-components-pure.md Outdated Show resolved Hide resolved
src/content/learn/keeping-components-pure.md Outdated Show resolved Hide resolved
src/content/learn/keeping-components-pure.md Outdated Show resolved Hide resolved
src/content/learn/keeping-components-pure.md Outdated Show resolved Hide resolved
src/content/learn/keeping-components-pure.md Outdated Show resolved Hide resolved
src/content/learn/keeping-components-pure.md Outdated Show resolved Hide resolved
@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@neighborhood999 neighborhood999 merged commit f9455ad into reactjs:main Oct 16, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants