Remove unused $status property #62
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@clue Can just use squash on merge, no? |
|
@kelunik We try to avoid squashing changes via GitHub's squash on merge. This will always lead to GitHub being the new committer and it will also add an extra commit. |
|
@kelunik Checking if this ticket will receive any updates or can we close this? Been open for a while and we want to avoid having issues or pull requests laying around for too long. It would involve squashing the two commits into one and then force pushing the new commit to GitHub in order for us to approve this. Or is there any way we can help this progressing? |
|
This ticket hasn't received any updated in a while, so I'll close this for now. We can always revisit this at a later time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.