Changed $stream from DuplexStreamInterface to ReadableStreamInterface…

… in Response constructor (#63) Changed $stream from DuplexStreamInterface to ReadableStreamInterface in Response constructor (#63)
reactphp · Oct 6, 2016 · f799ca6 · f799ca6
1 parent 4d367ff
commit f799ca6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/src/Response.php b/src/Response.php
@@ -3,7 +3,6 @@
 namespace React\HttpClient;
 
 use Evenement\EventEmitterTrait;
-use React\Stream\DuplexStreamInterface;
 use React\Stream\ReadableStreamInterface;
 use React\Stream\Util;
 use React\Stream\WritableStreamInterface;
@@ -25,7 +24,7 @@ class Response implements ReadableStreamInterface
     private $headers;
     private $readable = true;
 
-    public function __construct(DuplexStreamInterface $stream, $protocol, $version, $code, $reasonPhrase, $headers)
+    public function __construct(ReadableStreamInterface $stream, $protocol, $version, $code, $reasonPhrase, $headers)
     {
         $this->stream = $stream;
         $this->protocol = $protocol;
@@ -108,7 +107,7 @@ public function close(\Exception $error = null)
         $this->emit('end', array($error, $this));
 
         $this->removeAllListeners();
-        $this->stream->end();
+        $this->stream->close();
     }
 
     public function isReadable()

diff --git a/tests/ResponseTest.php b/tests/ResponseTest.php
@@ -51,7 +51,7 @@ public function responseShouldEmitEndEventOnEnd()
 
         $this->stream
             ->expects($this->at(0))
-            ->method('end');
+            ->method('close');
 
         $response->handleData('some data');
         $response->handleEnd();