Merge pull request #123 from clue-labs/whitespace-chunks

Ignore excessive whitespace in chunk header
reactphp · Feb 7, 2018 · f8ac7af · f8ac7af
2 parents 924baa2 + f20f7ad
commit f8ac7af
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/src/ChunkedStreamDecoder.php b/src/ChunkedStreamDecoder.php
@@ -103,7 +103,7 @@ protected function iterateBuffer()
                 list($lengthChunk) = explode(';', $lengthChunk, 2);
             }
             if ($lengthChunk !== '') {
-                $lengthChunk = ltrim($lengthChunk, "0");
+                $lengthChunk = ltrim(trim($lengthChunk), "0");
                 if ($lengthChunk === '') {
                     // We've reached the end of the stream
                     $this->reachedEnd = true;

diff --git a/tests/DecodeChunkedStreamTest.php b/tests/DecodeChunkedStreamTest.php
@@ -76,6 +76,13 @@ public function provideChunkedEncoding()
             ],
             'uppercase-chunk' => [
                 ["4\r\nWiki\r\n5\r\npedia\r\nE\r\n in\r\n\r\nchunks.\r\n0\r\n\r\n"],
+            ],
+            'extra-space-in-length-chunk' => [
+                [" 04 \r\nWiki\r\n5\r\npedia\r\nE\r\n in\r\n\r\nchunks.\r\n0\r\n\r\n"],
+            ],
+            'only-whitespace-is-final-chunk' => [
+                ["   \r\n\r\n"],
+                ""
             ]
         ];
     }