Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client Interface #86

Closed
wants to merge 1 commit into from
Closed

Client Interface #86

wants to merge 1 commit into from

Conversation

rcrosby256
Copy link

  • Adds a simple ClientInterface so that we can depend on abstractions rather than concretions :)

@WyriHaximus WyriHaximus requested review from jsor, WyriHaximus and clue May 19, 2017 16:45
@WyriHaximus
Copy link
Member

While I like the idea, I would prefer to include description of what is exactly expected from clients implementing this interface

@mdrost
Copy link
Contributor

mdrost commented Jun 4, 2017

IMHO if we are going into interfaces maybe we should think more about PSR7?

@WyriHaximus
Copy link
Member

IMHO if we are going into interfaces maybe we should think more about PSR7?

PSR-7 is on the roadmap, but we're focusing on PSR-7 phase 2 in react/http at the moment #79

@clue
Copy link
Member

clue commented Jan 18, 2018

I'm having to close this for now as it hasn't received any input in a while and it's unlikely this will get traction any time soon.

I think this is still a very relevant issue. We're looking into implementing PSR-7 interfaces via #41 soon, so we'll look into this again in the not too far future 👍 If you feel this was closed prematurely or want to pick this up again, please let us know and we can reopen this.

Thank you for your effort!

@clue clue closed this Jan 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants