Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advertiser domain report #968

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Advertiser domain report #968

merged 1 commit into from
Jan 8, 2025

Conversation

davidfischer
Copy link
Collaborator

Adds an advertiser domain report where they can see the top domains for their ads.

  • Adds a note/alert if the timeframe is earlier than when data began being collected.
  • We don't currently mention that some ads do not report their domain (eg. native ones) so this won't add up to the total in all cases. How should we mention that?

Screenshot

image

@davidfischer davidfischer requested a review from a team as a code owner December 19, 2024 23:30
@@ -126,6 +126,16 @@ <h6 class="text-muted">{{ advertiser }}</h6>
</a>
</li>

<li class="nav-item">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to test this behind a staff flag before rolling it out more widely?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine to just roll out. We can test it on staging but I think it should be fine.

@davidfischer davidfischer merged commit 0c126a7 into main Jan 8, 2025
1 check passed
@davidfischer davidfischer deleted the davidfischer/domain-report branch January 8, 2025 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants