Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable no_magic_numbers for Swift Testing code #5964

Open
2 tasks done
rberggreen opened this issue Jan 15, 2025 · 0 comments · May be fixed by #5968
Open
2 tasks done

Disable no_magic_numbers for Swift Testing code #5964

rberggreen opened this issue Jan 15, 2025 · 0 comments · May be fixed by #5968
Labels
enhancement Ideas for improvements of existing features and rules.

Comments

@rberggreen
Copy link

New Issue Checklist

Feature or Enhancement Proposal

It would be good disable the no_magic_numbers rule for Swift Testing code, for the same reason that it is already disabled by default for XCTest code and previews.

Image

Image
@SimplyDanny SimplyDanny added enhancement Ideas for improvements of existing features and rules. good first issue Issue to be taken up by new contributors yet unfamiliar with the project. and removed good first issue Issue to be taken up by new contributors yet unfamiliar with the project. labels Jan 15, 2025
@SimplyDanny SimplyDanny linked a pull request Jan 17, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Ideas for improvements of existing features and rules.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Exclude @Suite types and @Test functions from no_magic_numbers analysis SimplyDanny/SwiftLint
2 participants
@rberggreen @SimplyDanny