Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude @Suite types and @Test functions from no_magic_numbers analysis #5968

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SimplyDanny
Copy link
Collaborator

Resolves #5964.

@SwiftLintBot
Copy link

1 Warning
⚠️ This PR may need tests.
44 Messages
📖 Building this branch resulted in a binary size of 29489.84 KiB vs 29488.71 KiB when built on main (0% larger).
📖 Linting Aerial with this PR took 0.21 s vs 0.19 s on main (10% slower).
📖 Linting Alamofire with this PR took 0.19 s vs 0.18 s on main (5% slower).
📖 Linting Brave with this PR took 0.92 s vs 0.92 s on main (0% slower).
📖 Linting DuckDuckGo with this PR took 0.59 s vs 0.61 s on main (3% faster).
📖 Linting Firefox with this PR took 1.57 s vs 1.56 s on main (0% slower).
📖 Linting Kickstarter with this PR took 0.93 s vs 0.91 s on main (2% slower).
📖 Linting Moya with this PR took 0.12 s vs 0.13 s on main (7% faster).
📖 Linting NetNewsWire with this PR took 0.36 s vs 0.37 s on main (2% faster).
📖 Linting Nimble with this PR took 0.16 s vs 0.15 s on main (6% slower).
📖 Linting PocketCasts with this PR took 0.94 s vs 0.91 s on main (3% slower).
📖 Linting Quick with this PR took 0.12 s vs 0.12 s on main (0% slower).
📖 Linting Realm with this PR took 0.46 s vs 0.47 s on main (2% faster).
📖 Linting Sourcery with this PR took 0.3 s vs 0.3 s on main (0% slower).
📖 Linting Swift with this PR took 0.52 s vs 0.51 s on main (1% slower).
📖 Linting VLC with this PR took 0.22 s vs 0.22 s on main (0% slower).
📖 Linting Wire with this PR took 1.99 s vs 2.0 s on main (0% faster).
📖 Linting WordPress with this PR took 1.27 s vs 1.31 s on main (3% faster).
📖 This PR fixed a violation in Nimble: /Tests/NimbleTests/SwiftTestingSupportTest.swift:9:32: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in WordPress: /Modules/Tests/AsyncImageKitTests/ImageDownloaderTests.swift:124:45: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in WordPress: /Modules/Tests/AsyncImageKitTests/ImageDownloaderTests.swift:124:59: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in WordPress: /Modules/Tests/AsyncImageKitTests/ImageDownloaderTests.swift:139:62: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in WordPress: /Modules/Tests/AsyncImageKitTests/ImageDownloaderTests.swift:30:36: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in WordPress: /Modules/Tests/AsyncImageKitTests/ImageDownloaderTests.swift:30:49: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in WordPress: /Modules/Tests/AsyncImageKitTests/ImageDownloaderTests.swift:37:45: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in WordPress: /Modules/Tests/AsyncImageKitTests/ImageDownloaderTests.swift:37:58: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in WordPress: /Modules/Tests/AsyncImageKitTests/ImageDownloaderTests.swift:45:83: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in WordPress: /Modules/Tests/AsyncImageKitTests/ImageDownloaderTests.swift:49:36: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in WordPress: /Modules/Tests/AsyncImageKitTests/ImageDownloaderTests.swift:49:49: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in WordPress: /Modules/Tests/AsyncImageKitTests/ImageDownloaderTests.swift:75:37: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in WordPress: /Modules/Tests/AsyncImageKitTests/ImageDownloaderTests.swift:75:50: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in WordPress: /Modules/Tests/AsyncImageKitTests/ImageDownloaderTests.swift:85:52: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in WordPress: /Modules/Tests/AsyncImageKitTests/ImageDownloaderTests.swift:85:65: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in WordPress: /Modules/Tests/AsyncImageKitTests/ImageDownloaderTests.swift:97:45: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in WordPress: /Modules/Tests/AsyncImageKitTests/ImageDownloaderTests.swift:97:58: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in WordPress: /WordPress/WordPressTest/DataStoreTests.swift:27:53: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in WordPress: /WordPress/WordPressTest/DataStoreTests.swift:31:76: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in WordPress: /WordPress/WordPressTest/DataStoreTests.swift:32:42: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in WordPress: /WordPress/WordPressTest/DataStoreTests.swift:46:53: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in WordPress: /WordPress/WordPressTest/DataStoreTests.swift:50:76: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in WordPress: /WordPress/WordPressTest/DataStoreTests.swift:51:42: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in WordPress: /WordPress/WordPressTest/DataStoreTests.swift:63:53: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in WordPress: /WordPress/WordPressTest/MediaHostTests.swift:102:25: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in WordPress: /WordPress/WordPressTest/MediaHostTests.swift:87:25: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)

Generated by 🚫 Danger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable no_magic_numbers for Swift Testing code
2 participants