Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(status): correctly display duration of stopped workflows (#156) #156

Merged

Conversation

giuseppe-steduto
Copy link
Member

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.63%. Comparing base (a805040) to head (3b7da05).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #156      +/-   ##
==========================================
+ Coverage   83.59%   83.63%   +0.03%     
==========================================
  Files          38       38              
  Lines        3128     3135       +7     
==========================================
+ Hits         2615     2622       +7     
  Misses        426      426              
  Partials       87       87              
Files Coverage Δ
cmd/list.go 93.35% <100.00%> (+0.02%) ⬆️
cmd/status.go 96.29% <100.00%> (+0.02%) ⬆️
pkg/workflows/utils.go 100.00% <100.00%> (ø)

giuseppe-steduto added a commit to giuseppe-steduto/reana-client-go that referenced this pull request Feb 27, 2024
@giuseppe-steduto giuseppe-steduto force-pushed the fix-duration-stopped-workflows branch from 233c616 to 89c4b7e Compare February 27, 2024 14:11
mdonadoni pushed a commit to giuseppe-steduto/reana-client-go that referenced this pull request Mar 14, 2024
@mdonadoni mdonadoni force-pushed the fix-duration-stopped-workflows branch 2 times, most recently from a6551d8 to 66e8ae0 Compare March 14, 2024 13:15
@mdonadoni mdonadoni force-pushed the fix-duration-stopped-workflows branch from 66e8ae0 to 3b7da05 Compare March 14, 2024 13:38
Copy link
Member

@tiborsimko tiborsimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nicely 👍

Before change:

DURATION
14608313

After change:

DURATION 
4057251

@mdonadoni mdonadoni merged commit 3b7da05 into reanahub:master Mar 14, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cli: duration of stopped workflows is not displayed correctly
3 participants