Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

models: limit the number of restarts of a workflow #176

Merged
merged 1 commit into from
Jun 27, 2022

Conversation

mdonadoni
Copy link
Member

Considering issue #173, the limit is currently set to permit at most
nine restarts.

How to test: see #173

@codecov-commenter
Copy link

Codecov Report

Merging #176 (5b09cc1) into master (dd1b60e) will decrease coverage by 0.05%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #176      +/-   ##
==========================================
- Coverage   68.05%   68.00%   -0.06%     
==========================================
  Files           7        7              
  Lines         745      750       +5     
==========================================
+ Hits          507      510       +3     
- Misses        238      240       +2     
Impacted Files Coverage Δ
reana_db/config.py 0.00% <0.00%> (ø)
reana_db/models.py 88.65% <75.00%> (-0.12%) ⬇️

Copy link
Member

@audrium audrium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nicely!

Few minor observations:

  • Can you please add a note to the changelog?
  • Can you fix the commit message to link the PR with the issue?

Considering issue reanahub#173, the limit is currently set to permit at most
nine restarts.

Closes reanahub#173
@mdonadoni mdonadoni linked an issue Jun 27, 2022 that may be closed by this pull request
@audrium audrium merged commit 1e991ad into reanahub:master Jun 27, 2022
@mdonadoni mdonadoni deleted the limit-restarts branch October 13, 2022 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

models: incorrect run number assignment after many restarts
3 participants