-
-
Notifications
You must be signed in to change notification settings - Fork 250
mat2: add tables to docs & fix comments #469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Vincent Davis Jr <[email protected]>
@recp Rearranged some functions and changed parameter names for API consistency. Question with glms_mat2_(transpose)(mat2s m) Do we need to break this up into mat2s
glms_mat2_(transpose_to)(mat2s m);
void
glms_mat2_(transpose)(mat2s m); |
c462cc6
to
0f97854
Compare
There is no need to have |
@recp Okay good to know. Left that the same. Lastly wanted to update the docs format. So, that it's hopefully easier for new comers to understand the mathematics
Good? Or is it a bit too much? |
@EasyIP2023 the docs looks good many thanks. But I'm not sure about naming about
for instance glms_mat2_inv(mat2 src, mat2 dest) we are inverting src okay but also inverting given matrix which is Also just realized that |
@recp Okay cool cool. Will change functions param names when I find time and let you know. |
Signed-off-by: Vincent Davis Jr <[email protected]>
Signed-off-by: Vincent Davis Jr <[email protected]>
0f97854
to
27a3ddc
Compare
@recp Believe to be ready for another review. |
@EasyIP2023 the PR is merged, I may update param names later e.g Thanks for your contributions 🚀 |
No description provided.