Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for linked resource providers with no template #98

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Add support for linked resource providers with no template #98

merged 1 commit into from
Nov 13, 2023

Conversation

jkupferer
Copy link
Collaborator

This feature allows a ResourceProvider to reference another with different parameters or to combine resources without using a top-level binding resource.

@jkupferer
Add support for linked resource providers with no template
69097a6 
- This feature allows a ResourceProvider to reference another with
  different parameters or to combine resources without using a top-level
  binding resource.
9strands
9strands approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@9strands 9strands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Complete visual review of code completed, no errors seen in changes in the PR.

Uncertain of how to test these changes before approval, but I do see that tests have been updated in the tests directory.

@jkupferer jkupferer merged commit 0776cfc into main Nov 13, 2023
1 check passed
@jkupferer jkupferer deleted the linked-provider-without-template branch November 13, 2023 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@9strands 9strands 9strands approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkupferer @9strands