Skip to content

Fix issue with using wrong file for multiple lines. #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2025
Merged

Conversation

dvalinrh
Copy link
Contributor

Description

Fixes code in validate_line to use the right file when we havethe directive %_multiples. Without this change we can get false error reporting.

Before/After Comparison

Before: Results validation involving multiple lines may report incorrect status.
After: Proper run status is reported for multiple line directive.

Clerical Stuff

This closes #69

Relates to JIRA: RPOPC-500

Testing

Verified that when fixed, that we get the proper results when using %_multiples directive.

@dvalinrh dvalinrh requested a review from a team June 23, 2025 16:42
@dvalinrh dvalinrh self-assigned this Jun 23, 2025
Copy link

This relates to RPOPC-500

Copy link
Member

@kdvalin kdvalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kdvalin kdvalin added the group_review_lgtm Indicates approval after a group review meeting label Jun 24, 2025
@dvalinrh dvalinrh merged commit ae7f503 into main Jun 25, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
group_review_lgtm Indicates approval after a group review meeting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using wrong file in validate_lines for multipe entries.
2 participants