bootloader: export Grub variables to make them available in submenus #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without exporting the grub variables, they are only available in the main grub menu[0]. When descending in a submenu (like in default Debian for example), tuned_* variable are expanded to the empty string and, so, tuned kernel cmdline tuning is effectively disabled. With the export, variables are available in submenus and tuned tuning is applied as expected. [0]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1094201#10 Signed-off-by: Yoann Congal <[email protected]>
|
LGTM, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without exporting the grub variables, they are only available in the main grub menu0. When descending in a submenu (like in default Debian for example), tuned_* variable are expanded to the empty string and, so, tuned kernel cmdline tuning is effectively disabled.
With the export, variables are available in submenus and tuned tuning is applied as expected.