Skip to content

RI-7347: Tips section slightly broken: links, voting... #4875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
+8 −8
Open

RI-7347: Tips section slightly broken: links, voting... #4875

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0c2b730
fix the padding of "Is this useful?" text at the end of the insight
dantovska Aug 19, 2025
cc5d824
change link color so links stand out
dantovska Aug 19, 2025
f8f5c1f
add a div around the contents so they are not spread through differen…
dantovska Aug 19, 2025
52806b7
remove the blueish color from the copy text component
dantovska Aug 19, 2025
1df0c42
remove this not defined nor used style
dantovska Aug 19, 2025
655a338
[TO BE REFACTORED WITH THEME COLOR] Change the recommendationsBgColor…
dantovska Aug 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions redisinsight/ui/src/components/recommendation/content-element/ContentElement.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ const ContentElement = (props: Props) => {
case 'link':
return (
<Link
color="subdued"
key={`${telemetryName}-${idx}`}
data-testid={`link-${telemetryName}-${idx}`}
target="_blank"
Expand Down
4 changes: 2 additions & 2 deletions redisinsight/ui/src/components/recommendation/recommendation-body/RecommendationBody.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,12 @@ export interface Props {
}

const RecommendationBody = ({ elements = [], ...rest }: Props) => (
<>
<div>
{// eslint-disable-next-line react/no-array-index-key
elements?.map((item, idx) => (
<ContentElement key={idx} content={item} idx={idx} {...rest} />
))}
</>
</div>
)

export default RecommendationBody
5 changes: 2 additions & 3 deletions ...c/components/recommendation/recommendation-copy-component/RecommendationCopyComponent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,16 +47,15 @@ const RecommendationCopyComponent = ({
Example of a key that may be relevant:
</Text>
<div className={styles.keyNameWrapper}>
<ColorText
color="subdued"
<Text
className={cx(styles.keyName, 'truncateText', {
[styles.dbAnalysis]: !live,
})}
component="div"
data-testid="recommendation-key-name"
>
{formattedName}
</ColorText>
</Text>
<IconButton
onClick={handleCopy}
className={styles.btn}
Expand Down
2 changes: 1 addition & 1 deletion redisinsight/ui/src/components/recommendation/recommendation-voting/RecommendationVoting.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ const RecommendationVoting = ({
gap={live ? 'none' : 'l'}
data-testid="recommendation-voting"
>
<Text size="m" className={cx({ [styles.highlightText]: live })}>
<Text size="m">
Is this useful?
</Text>
<div className="voteContent">
Expand Down
2 changes: 1 addition & 1 deletion ...side-panels/panels/live-time-recommendations/components/recommendation/styles.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@
justify-content: center;
border-radius: 8px;
background-color: var(--recommendationsBgColor) !important;
padding: 4px 0;
padding: 4px 0 4px 10px;
:global {
.voteContent {
margin-left: 6px !important;
Expand Down
2 changes: 1 addition & 1 deletion redisinsight/ui/src/styles/themes/light_theme/_theme_color.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ $recommendationBorderColor: #3953c3;


// Recommendations
$recommendationsBgColor: #FFFFFF;
$recommendationsBgColor: #F0F0F0;
$recommendationBgColor: #F6F7F9;
$recommendationLiveBorderColor: #B37A1E;
$recommendationColor: #415681;
Expand Down
Loading