RI-7372: make "Manage indexes" a panel #4877
Open
+364
−462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KrumTy
commented
Aug 19, 2025
| }, | ||
| }) | ||
| } | ||
| }, []) |
There was a problem hiding this comment.
no dependencies as it's explicitly meant to run once per mount as per usage
KrumTy
commented
Aug 19, 2025
Comment on lines
+7
to
+13
| export const useTelemetryMountEvent = ( | ||
| onMountEvent: TelemetryEvent, | ||
| onUnmountEvent?: TelemetryEvent, | ||
| eventData?: EventData, | ||
| ) => { | ||
| const { instanceId } = useParams<{ instanceId: string }>() | ||
|
|
There was a problem hiding this comment.
this encapsulates some event tracking logic that was previously linked to various click events and split across components.
The use case - when expanding/collapsing the right panel, an event should be logged
Code Coverage - Frontend unit tests
Test suite run success5072 tests passing in 667 suites. Report generated by 🧪jest coverage report action from 6c32fba |
KrumTy
requested review from
pawelangelow,
dantovska,
ArtemHoruzhenko,
pd-redis and
valkirilov
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description