Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add default threads count about NioEventLoopGroup #3221

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

brido4125
Copy link

@brido4125 brido4125 commented Mar 19, 2025

add NioEventLoopGroup default threads counts in AbstractRedisClient javadoc.

Make sure that:

  • You have read the contribution guidelines.
  • You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
  • You applied code formatting rules using the mvn formatter:format target. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.

@tishun
Copy link
Collaborator

tishun commented Mar 24, 2025

Hey @brido4125 ,
can we take a step back and discuss the issue.

I assume you found it hard to understand the defaults, correct? Would it make sense to add this to the documentation instead (not sure how many users dig in the source code to that level) ?

@tishun tishun added the status: waiting-for-feedback We need additional information before we can continue label Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting-for-feedback We need additional information before we can continue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants