Skip to content

Use InfoPatterns enum for ReplicaTopologyProvider pattern management #3264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Use InfoPatterns enum for ReplicaTopologyProvider pattern management #3264

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c816477
Use InfoPatterns enum for ReplicaTopologyProvider pattern management
ori0o0p Apr 18, 2025
78b1349
Apply code formatting to ReplicaTopologyProvider.java
ori0o0p Apr 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 39 additions & 17 deletions src/main/java/io/lettuce/core/masterreplica/ReplicaTopologyProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,26 +38,47 @@

/**
* Topology provider using Redis Standalone and the {@code INFO REPLICATION} output. Replicas are listed as {@code slaveN=...}
* entries.
* entries. This provider parses the {@code INFO REPLICATION} output to discover master and replica nodes, using regular
* expression patterns defined in the {@link InfoPatterns} enum.
*
* @author Mark Paluch
* @since 4.1
*/
class ReplicaTopologyProvider implements TopologyProvider {

public static final Pattern ROLE_PATTERN = Pattern.compile("^role\\:([a-z]+)$", Pattern.MULTILINE);
/**
* Enum containing regular expression patterns for parsing Redis {@code INFO REPLICATION} output. Each constant provides a
* compiled {@link Pattern} and a {@link Matcher} for convenient pattern matching.
*/
enum InfoPatterns {

ROLE(Pattern.compile("^role\\:([a-z]+)$", Pattern.MULTILINE)),

SLAVE(Pattern.compile("^slave(\\d+)\\:([a-zA-Z\\,\\=\\d\\.\\:\\-]+)$", Pattern.MULTILINE)),

MASTER_HOST(Pattern.compile("^master_host\\:([a-zA-Z\\,\\=\\d\\.\\:\\-]+)$", Pattern.MULTILINE)),

MASTER_PORT(Pattern.compile("^master_port\\:(\\d+)$", Pattern.MULTILINE)),

public static final Pattern SLAVE_PATTERN = Pattern.compile("^slave(\\d+)\\:([a-zA-Z\\,\\=\\d\\.\\:\\-]+)$",
Pattern.MULTILINE);
IP(Pattern.compile("ip\\=([a-zA-Z\\d\\.\\:\\-]+)")),

public static final Pattern MASTER_HOST_PATTERN = Pattern.compile("^master_host\\:([a-zA-Z\\,\\=\\d\\.\\:\\-]+)$",
Pattern.MULTILINE);
PORT(Pattern.compile("port\\=([\\d]+)"));

public static final Pattern MASTER_PORT_PATTERN = Pattern.compile("^master_port\\:(\\d+)$", Pattern.MULTILINE);
private final Pattern pattern;

public static final Pattern IP_PATTERN = Pattern.compile("ip\\=([a-zA-Z\\d\\.\\:\\-]+)");
InfoPatterns(Pattern pattern) {
this.pattern = pattern;
}

public Pattern getPattern() {
return pattern;
}

public static final Pattern PORT_PATTERN = Pattern.compile("port\\=([\\d]+)");
public Matcher matcher(String input) {
return pattern.matcher(input);
}

}

private static final InternalLogger logger = InternalLoggerFactory.getInstance(ReplicaTopologyProvider.class);

Expand Down Expand Up @@ -126,7 +147,7 @@ protected List<RedisNodeDescription> getNodesFromInfo(String info) {

private RedisNodeDescription getCurrentNodeDescription(String info) {

Matcher matcher = ROLE_PATTERN.matcher(info);
Matcher matcher = InfoPatterns.ROLE.matcher(info);

if (!matcher.find()) {
throw new IllegalStateException("No role property in info " + info);
Expand All @@ -139,12 +160,12 @@ private List<RedisNodeDescription> getReplicasFromInfo(String info) {

List<RedisNodeDescription> replicas = new ArrayList<>();

Matcher matcher = SLAVE_PATTERN.matcher(info);
Matcher matcher = InfoPatterns.SLAVE.matcher(info);
while (matcher.find()) {

String group = matcher.group(2);
String ip = getNested(IP_PATTERN, group, 1);
String port = getNested(PORT_PATTERN, group, 1);
String ip = getNested(InfoPatterns.IP, group, 1);
String port = getNested(InfoPatterns.PORT, group, 1);

replicas.add(new RedisMasterReplicaNode(ip, Integer.parseInt(port), redisURI, RedisInstance.Role.SLAVE));
}
Expand All @@ -154,8 +175,8 @@ private List<RedisNodeDescription> getReplicasFromInfo(String info) {

private RedisNodeDescription getMasterFromInfo(String info) {

Matcher masterHostMatcher = MASTER_HOST_PATTERN.matcher(info);
Matcher masterPortMatcher = MASTER_PORT_PATTERN.matcher(info);
Matcher masterHostMatcher = InfoPatterns.MASTER_HOST.matcher(info);
Matcher masterPortMatcher = InfoPatterns.MASTER_PORT.matcher(info);

boolean foundHost = masterHostMatcher.find();
boolean foundPort = masterPortMatcher.find();
Expand All @@ -170,14 +191,15 @@ private RedisNodeDescription getMasterFromInfo(String info) {
return new RedisMasterReplicaNode(host, port, redisURI, RedisInstance.Role.UPSTREAM);
}

private String getNested(Pattern pattern, String string, int group) {
private String getNested(InfoPatterns pattern, String string, int group) {

Matcher matcher = pattern.matcher(string);
if (matcher.find()) {
return matcher.group(group);
}

throw new IllegalArgumentException("Cannot extract group " + group + " with pattern " + pattern + " from " + string);
throw new IllegalArgumentException(
"Cannot extract group " + group + " with pattern " + pattern.getPattern() + " from " + string);

}

Expand Down