Fix http_client input connect bug #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This issue was uncovered because the `http_client` components would not try to reconnect if the internal codec couldn't be initialised. The fix addresses the issue at the scanner level. `h.codecCtor.Create` will return a `*service.OwnedScanner`, but `h.codec` has type `codec.DeprecatedFallbackStream`, so if we get an error from `h.codecCtor.Create`, the `h.codec != nil` check in `Connect` will be true, so Benthos will think the input is connected. This can happen if the codec specification isn't compatible with the received data. Signed-off-by: Mihai Todor <[email protected]>
mihaitodor
force-pushed
the
mihaitodor-fix-http-client-input-connect-bug
branch
from
60d5253 to
ba69e0f
Compare
|
I ended up refining the fix since any component which uses scanners through the old |
rockwotj
approved these changes
Mar 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue was uncovered because the
http_clientcomponents would not try to reconnect if the internal codec couldn't be initialised. The fix addresses the issue at the scanner level.h.codecCtor.Createwill return a*service.OwnedScanner, buth.codechas typecodec.DeprecatedFallbackStream, so if we get an error fromh.codecCtor.Create, theh.codec != nilcheck inConnectwill be true, so Benthos will think the input is connected. This can happen if the codec specification isn't compatible with the received data.