Skip to content

DOC-1168 Private Link for Azure in UI #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

micheleRP
Copy link
Contributor

@micheleRP micheleRP commented May 20, 2025

Description

This pull request introduces support for configuring Azure Private Link through the Redpanda Cloud UI. It includes a new guide for Azure Private Link in the UI, updated navigation menus, and enhanced descriptions across related pages. It also removed the "Limited availability" label on Azure Private Link, so users no longer need to contact Support to use it in the Cloud API.

New Feature: Azure Private Link in the UI

Documentation Updates for Navigation

  • modules/ROOT/nav.adoc: Updated navigation to include links to the new Azure Private Link UI guide under both BYOC and Dedicated sections. [1] [2]

Improved Descriptions for Clarity

  • modules/networking/pages/aws-privatelink.adoc: Updated the description to specify that the guide is for configuring AWS PrivateLink with the Cloud API.
  • modules/networking/pages/azure-private-link.adoc: Updated the description and added a note linking to the new UI-based configuration guide for Azure Private Link.
  • modules/networking/pages/byoc/index.adoc and modules/networking/pages/dedicated/index.adoc: Updated descriptions to include Azure Private Link alongside other private networking options. [1] [2]

What's New Section

Resolves https://redpandadata.atlassian.net/browse/DOC-1168
Review deadline:

Page previews

Configure Azure Private Link in the Cloud UI

Checks

  • New feature
  • Content gap
  • Support Follow-up
  • Small fix (typos, links, copyedits, etc)

@micheleRP micheleRP requested a review from a team as a code owner May 20, 2025 21:16
Copy link

netlify bot commented May 20, 2025

Deploy Preview for rp-cloud ready!

Name Link
🔨 Latest commit 1e9a37c
🔍 Latest deploy log https://app.netlify.com/projects/rp-cloud/deploys/682fa04e5cde2600083645ce
😎 Deploy Preview https://deploy-preview-301--rp-cloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

coderabbitai bot commented May 20, 2025

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

📝 Walkthrough

Walkthrough

The changes introduce a new documentation page detailing how to configure Azure Private Link for Redpanda Cloud clusters using the Cloud UI. Navigation references to this new guide are added under relevant sections for both BYOC and Dedicated Azure networking. Additionally, the metadata descriptions for several networking documentation pages are updated to explicitly mention Azure Private Link alongside other private networking options. A new feature announcement about Azure Private Link configuration in the UI is also added to the "What's New" section. No code or API changes are present; all modifications are documentation-focused.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Redpanda Cloud UI
    participant Azure VNet

    User->>Redpanda Cloud UI: Access cluster creation/settings
    User->>Redpanda Cloud UI: Select "Private connection" and enable Azure Private Link
    Redpanda Cloud UI->>Azure VNet: Initiate Private Link endpoint service
    Azure VNet-->>Redpanda Cloud UI: Confirm endpoint setup
    Redpanda Cloud UI-->>User: Display connection URLs and status
    User->>Azure VNet: Access Redpanda services via Private Link
Loading

Assessment against linked issues

Objective Addressed Explanation
Document feature: PrivateLink support for Azure (Frontend) (DOC-1168)

Suggested reviewers

  • simon0191
  • Feediver1

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (11)
modules/networking/pages/azure-private-link.adoc (1)

2-2: Description updated for Cloud API—consider cross-linking UI guide
The new description correctly emphasizes the Cloud API setup. For consistency with the AWS PrivateLink docs and to help users find the UI-based instructions, consider adding a note near the top that points to the UI configuration guide.

Example diff:

 include::shared:partial$feature-flag.adoc[]
+
+NOTE: For UI-based configuration of Azure Private Link, see xref:networking:configure-private-link-in-ui.adoc[Configure Azure Private Link in the Cloud UI].
modules/get-started/pages/whats-new-cloud.adoc (1)

12-14: Fix preposition in announcement sentence
The phrase “configure Azure Private Link to your … cluster” should use “for” rather than “to” for clearer grammar.

Example diff:

- You can now xref:networking:configure-private-link-in-ui.adoc[configure Azure Private Link] to your BYOC or Dedicated cluster using the Cloud UI. 
+ You can now xref:networking:configure-private-link-in-ui.adoc[configure Azure Private Link] for your BYOC or Dedicated cluster using the Cloud UI. 
modules/ROOT/nav.adoc (2)

34-34: New Azure Private Link UI navigation link added
The xref to configure-private-link-in-ui.adoc correctly integrates the new guide under the BYOC Azure networking section. Please confirm that the referenced file path matches the actual file location. For consistency with other UI guides (e.g., AWS/GCP), consider specifying an explicit link title in square brackets or verifying naming conventions.


46-46: Add UI link for Dedicated Azure Private Link
This navigation entry mirrors the BYOC section and improves discoverability for Dedicated clusters. Ensure that the path networking:configure-private-link-in-ui.adoc aligns with the guide’s filename and consider adding a descriptive label in the brackets for clarity.

modules/networking/pages/configure-private-link-in-ui.adoc (7)

4-4: Clarify “existing public cluster” scope
The NOTE refers to “existing public cluster,” which might overlap with new clusters or confuse readers about cluster types. Consider rephrasing to “existing cluster” or explicitly stating “clusters created without Private Link” to remove ambiguity.


6-6: Unify networking terminology
This paragraph mixes Azure (“VNet”) and AWS-style (“VPC”) terms. To avoid confusion, replace “Redpanda VPC” with “Redpanda virtual network” or add a brief note explaining that our service uses a VPC abstraction even in Azure.


8-12: Improve bullet specificity

  • Prefix bullets with “Azure Private Link” for parallelism (e.g., “Azure Private Link allows overlapping…”).
  • Ensure the CIDR-ranges xref displays as intended without trailing punctuation.
    These are minor copy edits to align the style with surrounding docs.

15-17: Fix Azure CLI link syntax
The external link to the Azure CLI guide includes a caret (^) in the bracket, which may render as a footnote marker. Remove the caret for a clean label:

https://...-latest[Azure CLI]

18-18: Standardize TIP admonition style
Rather than inline “TIP:”, consider using an Asciidoc admonition block for consistency across guides:

[TIP]
====
In Kafka clients, set `connections.max.idle.ms` to a value less than 350 seconds.
====

20-26: Trim trailing whitespace and normalize list formatting

  • Remove extra spaces at the ends of lines 24 and 25.
  • Confirm that nested ordered sub-steps use consistent dot notation.
    This cleanup will prevent rendering artifacts in the HTML/PDF outputs.

45-47: Convert disable step into ordered list
For consistency with the “Enable” sections, consider presenting the disable instruction as a numbered list item:

. On the Cluster settings page, click *Disable* for Private Link.  
. Note: Existing connections close when disabled; re-enable to restore access.

This aligns styling across provider sections.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 02a08ba and 2f98c68.

📒 Files selected for processing (7)
  • modules/ROOT/nav.adoc (2 hunks)
  • modules/get-started/pages/whats-new-cloud.adoc (1 hunks)
  • modules/networking/pages/aws-privatelink.adoc (1 hunks)
  • modules/networking/pages/azure-private-link.adoc (1 hunks)
  • modules/networking/pages/byoc/index.adoc (1 hunks)
  • modules/networking/pages/configure-private-link-in-ui.adoc (1 hunks)
  • modules/networking/pages/dedicated/index.adoc (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Redirect rules - rp-cloud
  • GitHub Check: Header rules - rp-cloud
  • GitHub Check: Pages changed - rp-cloud
🔇 Additional comments (6)
modules/networking/pages/dedicated/index.adoc (1)

2-2: Metadata description aligned
The description now correctly includes Azure Private Link alongside AWS PrivateLink and GCP Private Service Connect. This update is clear and matches the BYOC index page.

modules/networking/pages/aws-privatelink.adoc (1)

2-2: Metadata description aligned with Cloud API
The updated description emphasizes setup via the Cloud API and matches the page title. The in-page note already points to the UI guide, maintaining consistency with Azure and GCP docs.

modules/networking/pages/byoc/index.adoc (1)

2-2: Metadata description aligned
The description now includes Azure Private Link alongside AWS PrivateLink and GCP Private Service Connect. It’s consistent with the Dedicated networking page.

modules/networking/pages/configure-private-link-in-ui.adoc (3)

27-32: Enable endpoint service for existing clusters
The steps are clear, correctly numbered, and follow the same pattern as the “new clusters” section. No changes needed here.


33-37: Access instructions and include macro
The “How to Connect” reference and the include path for the partial (private-links-access-rp-services-through-vpc.adoc) are accurate and consistent with other documentation.


39-43: Test connection section
Good use of an ordered header and partial include for the connection tests. The guidance on using rpk or cURL is helpful and correctly referenced.

@micheleRP micheleRP requested review from david-yu and chapmanc May 20, 2025 21:21
micheleRP added 2 commits May 21, 2025 15:16
…t-for-Azure-Frontend

# Conflicts:
#	modules/get-started/pages/whats-new-cloud.adoc
@micheleRP
Copy link
Contributor Author

status: marking this as blocked until this fix: https://redpandadata.atlassian.net/browse/UX-218

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants