Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc-752 Update FIPS to add tabs with one for RHEL and one for Debian/Ubuntu #914

Merged
merged 13 commits into from
Mar 18, 2025

Conversation

Feediver1
Copy link
Contributor

@Feediver1 Feediver1 commented Dec 11, 2024

Description

Resolves https://redpandadata.atlassian.net/browse/DOC-752
Review deadline: Dec 11

Page previews

Preview

Checks

  • New feature
  • Content gap
  • Support Follow-up
  • Small fix (typos, links, copyedits, etc)

@Feediver1 Feediver1 requested a review from a team as a code owner December 11, 2024 02:13
Copy link

netlify bot commented Dec 11, 2024

Deploy Preview for redpanda-docs-preview ready!

Name Link
🔨 Latest commit bfe9701
🔍 Latest deploy log https://app.netlify.com/sites/redpanda-docs-preview/deploys/67d43fe77f4f470008d92960
😎 Deploy Preview https://deploy-preview-914--redpanda-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@KavyaShivashankar KavyaShivashankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RHEL package manager is YUM. the command for RHEL should change to sudo yum install instead of sudo apt install

Also the command needs to include repdanda-fips package
sudo yum install -y repdanda-fips redpanda-rpk-fips

@Deflaimun
Copy link
Contributor

This PR could also include this issue
https://redpandadata.atlassian.net/browse/DOC-859

Copy link
Contributor

@Deflaimun Deflaimun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check suggestions

@Deflaimun
Copy link
Contributor

sudo apt install -y redpanda-rpk-fips redpanda-fips

this line should be changed to yum too

Copy link
Contributor

@michael-redpanda michael-redpanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the fixes!

@Feediver1 Feediver1 requested a review from Deflaimun December 18, 2024 18:58
@Deflaimun Deflaimun dismissed their stale review December 20, 2024 21:39

Lifting blocker

Copy link
Contributor

hyperlint-ai bot commented Mar 13, 2025

PR Change Summary

Updated the FIPS compliance documentation to include separate installation instructions for RHEL and Debian/Ubuntu.

  • Added tabs for RHEL and Debian/Ubuntu installation instructions for FIPS compliance.
  • Provided specific installation commands for both RHEL and Debian/Ubuntu.
  • Included notes on alternative installation methods for FIPS compliance.

Modified Files

  • modules/deploy/partials/linux/install-fips.adoc

How can I customize these reviews?

Check out the Hyperlint AI Reviewer docs for more information on how to customize the review.

If you just want to ignore it on this PR, you can add the hyperlint-ignore label to the PR. Future changes won't trigger a Hyperlint review.

Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add hyperlint-ignore to the PR to ignore the link check for this PR.

What is Hyperlint?

Hyperlint is an AI agent that helps you write, edit, and maintain your documentation.

Learn more about the Hyperlint AI reviewer and the checks that we can run on your documentation.

Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com>
Feediver1 and others added 2 commits March 13, 2025 15:59
Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com>
@KavyaShivashankar
Copy link

thanks for the fixes. looks good.

Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com>
@Feediver1 Feediver1 requested review from a team and removed request for Deflaimun March 14, 2025 14:42
@Feediver1 Feediver1 merged commit a5e40a1 into main Mar 18, 2025
10 checks passed
@Feediver1 Feediver1 deleted the Doc-752 branch March 18, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants