Add ListOffsets flag for more control on metrics #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
yalindogusahin
force-pushed
the
master
branch
from
db58eec to
9bc002a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Feature] Add Offset Flag to Disable Offset Collection
Add configuration options to activate/deactivate ListOffsets metrics.
Added Features:
New Configuration Flag:
Topics.ListOffsets: A boolean flag to enable or disable offset collection.
When set to false, the collection of low watermark and high watermark metrics is skipped. Therefore you can scrape topic configurations only.
Testing:
Verified that offset metrics are collected when Topics.ListOffsets=true.
Verified that no offset metrics are collected when Topics.ListOffsets=false.
Verified that offsets metrics are collected when default variable which is true