[CORE-8530] Handle out-of-sync producers by writing records to past-schema parquet #24955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
oleiman
force-pushed
the
dlib/core-8530/write-historical-schema
branch
from
20ddb11 to
8e9d51a
Compare
oleiman
force-pushed
the
dlib/core-8530/write-historical-schema
branch
4 times, most recently
from
b4ffa8f to
0d4f346
Compare
This comment was marked as outdated.
This comment was marked as outdated.
oleiman
force-pushed
the
dlib/core-8530/write-historical-schema
branch
2 times, most recently
from
770eb1d to
4940eea
Compare
CI test resultstest results on build#61406
test results on build#61444
test results on build#61469
|
oleiman
force-pushed
the
dlib/core-8530/write-historical-schema
branch
from
4940eea to
ac6735d
Compare
andrwng
reviewed
Jan 31, 2025
Comment on lines
+13
to
+15
| namespace iceberg { | ||
| bool schemas_equivalent(const struct_type& source, const struct_type& dest) { | ||
| chunked_vector<const nested_field*> source_stk; |
There was a problem hiding this comment.
Could use some simple tests?
There was a problem hiding this comment.
Maybe same with table metadata and/or catalog_schema_manager
There was a problem hiding this comment.
yeah fair point. slipped my mind.
Comment on lines
291
to
292
| auto source_copy = schema->schema_struct.copy(); | ||
| auto compat_res = check_schema_compat(dest_type, schema->schema_struct); |
There was a problem hiding this comment.
Not necessarily related to this PR, but this seems like a really easy footgun to hit. If the solution in general is to make a copy of the struct beforehand, should we make check_schema_compat take the source schema as non-const?
There was a problem hiding this comment.
yeah good point. perhaps it would be most clear to pass by value.
Checks whether two structs are precisely equivalent[1] using a simultaneous depth-first traversal. The use case is for performing schema lookups on cached table metadata by type rather than by ID. [1] - Exclusive of IDs but inclusive of order. Signed-off-by: Oren Leiman <[email protected]>
Search for a schema that matches the provided type. Signed-off-by: Oren Leiman <[email protected]>
For catalog_schema_manager, we can use this to perform a type-wise schema lookup on cached metadata, resulting in table_info bound to an arbitrary schema rather (possibly) other than the current table schema. Also update catalog_schema_manager::get_ids_from_table_meta to try a type-wise lookup before performing the usual compat check. This way we can short-circuit a schema update if the desired schema is already present in the table. Also pass source struct to check_schema_compat by value to avoid polluting cached table metadata with compat annotations. Signed-off-by: Oren Leiman <[email protected]>
Rather than current schema ID. By this point we should have ensured that the record schema exists in the table (either historically or currently). This change lets us look past the current schema to build a writer for historical data. Signed-off-by: Oren Leiman <[email protected]>
Signed-off-by: Oren Leiman <[email protected]>
oleiman
force-pushed
the
dlib/core-8530/write-historical-schema
branch
from
ac6735d to
f5a8ad8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
builds on #24862 . interesting commits start at e215bfe
Backports Required
Release Notes