config: add iceberg_rest_catalog_authentication_mode
#24986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Retry command for Build#61413please wait until all jobs are finished before running the slash command |
WillemKauf
force-pushed
the
iceberg_authentication_properties
branch
2 times, most recently
from
f1ecafb to
819b3f9
Compare
WillemKauf
force-pushed
the
iceberg_authentication_properties
branch
from
819b3f9 to
2b38389
Compare
CI test resultstest results on build#61423
test results on build#61438
test results on build#61474
|
WillemKauf
force-pushed
the
iceberg_authentication_properties
branch
2 times, most recently
from
1a892e9 to
bb87125
Compare
dotnwat
reviewed
Jan 31, 2025
Comment on lines
142
to
143
| std::optional<iceberg::rest_client::credentials>& credentials, | ||
| std::optional<iceberg::rest_client::oauth_token>& token) { |
There was a problem hiding this comment.
should we just return a struct or pair?
There was a problem hiding this comment.
Sure, happy to change this from in/out parameters to a return type if that would be more ergonomic.
There was a problem hiding this comment.
we generally don't use out-parameters unless the isn't a good alternative. struct credentials_or_token { ... };
For allowing the user to specify a uri to an OAuth2 server for use in authenticating requests made by the `catalog_client` to the catalog.
For configuring the authentication method used for the `catalog_client`
requests made to the catalog.
There are three possible values for this `enum`:
1. `::none`, where no authentication is attempted.
2. `::bearer`, where the token provided via `iceberg_rest_catalog_token`
is used for authentication.
3. `::oauth2`, where the client credentials defined via
`iceberg_rest_catalog_client_id/secret` are used to retrieve
an access token for future use.
WillemKauf
force-pushed
the
iceberg_authentication_properties
branch
from
bb87125 to
a5b738a
Compare
|
Force push to:
|
Depending on authentication settings, we may either construct user credentials for use with the OAuth2 endpoint for retrieving a token, construct the token directly, or do nothing at all.
WillemKauf
force-pushed
the
iceberg_authentication_properties
branch
from
a5b738a to
84e8449
Compare
|
Force push to:
|
WillemKauf
force-pushed
the
iceberg_authentication_properties
branch
from
84e8449 to
493a2a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
iceberg_rest_catalog_authentication_modeandiceberg_rest_catalog_oauth2_server_uriconfiguration options.Backports Required
Release Notes